Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend/local: fix panic while lightning quits (#33738) #33804

Open
wants to merge 1 commit into
base: release-5.4
Choose a base branch
from

Conversation

lichunzhu
Copy link
Contributor

cherry-pick #33738 to release-5.4
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/33802

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/33802:release-6.0-15a01fa50a7c

What problem does this PR solve?

Issue Number: close #33524

Problem Summary: as the issue

What is changed and how it works?

  1. fix the panic log while lightning quits. It's caused by Close pebble before ingestSST for loop quits by check db before ingest.
  2. add recover for places that are likely to panic.

Check List

Tests

  • Unit test
  • Integration test

Side effects

None

Documentation

None

Release note

None

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. labels Apr 8, 2022
@ti-chi-bot
Copy link
Member

@lichunzhu: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 8, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Apr 8, 2022

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Attention: Patch coverage is 30.76923% with 9 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-5.4@b1c5a67). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-5.4     #33804   +/-   ##
================================================
  Coverage               ?   63.7852%           
================================================
  Files                  ?        775           
  Lines                  ?     255584           
  Branches               ?          0           
================================================
  Hits                   ?     163025           
  Misses                 ?      79616           
  Partials               ?      12943           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/5.4-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants