Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infoschema: add column of Has_more_result into table of slow_query #33840

Merged
merged 3 commits into from
Apr 11, 2022
Merged

infoschema: add column of Has_more_result into table of slow_query #33840

merged 3 commits into from
Apr 11, 2022

Conversation

likzn
Copy link
Contributor

@likzn likzn commented Apr 9, 2022

What problem does this PR solve?

Issue Number: close #33733

Problem Summary: SlowQueryLogItems struct has Has_more_result variable but slow_query table has not this column so that when we select * form infomation.slow_query ,the Has_more_result will be absent

What is changed and how it works?

Add column of Has_more_result into slow_query table

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 9, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • crazycs520
  • jackysp

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 9, 2022
@likzn likzn changed the title infoschema: add column of Has_more_result into table of slow_query infoschema: add column of Has_more_result into table of slow_query Apr 9, 2022
@likzn
Copy link
Contributor Author

likzn commented Apr 9, 2022

/cc @jackysp @zimulala @aytrack PTAL if free

@ti-chi-bot
Copy link
Member

@likzn: GitHub didn't allow me to request PR reviews from the following users: PTAL, if, free.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @jackysp @zimulala @aytrack PTAL if free

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jackysp
jackysp approved these changes Apr 11, 2022
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 11, 2022
@jackysp
Copy link
Member

jackysp commented Apr 11, 2022

PTAL @crazycs520

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 11, 2022
@jackysp
Copy link
Member

jackysp commented Apr 11, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 83f43fa

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 11, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Apr 11, 2022

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/83f43faa70bd4a583c7f4ecdf5f01eae4cb216c2

@ti-chi-bot ti-chi-bot merged commit 11681b4 into pingcap:master Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazycs520 crazycs520 crazycs520 approved these changes

@jackysp jackysp jackysp approved these changes

@zimulala zimulala Awaiting requested review from zimulala

@aytrack aytrack Awaiting requested review from aytrack

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Has_more_results missing in SLOW_QUERY table
5 participants
@likzn @ti-chi-bot @jackysp @sre-bot @crazycs520