Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Add more grafana charts for pd http api request #33936

Merged
merged 16 commits into from
Apr 14, 2022
Merged

*: Add more grafana charts for pd http api request #33936

merged 16 commits into from
Apr 14, 2022

Conversation

lcwangchao
Copy link
Collaborator

@lcwangchao lcwangchao commented Apr 13, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #33916

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Add pd request ops and request fail ops chart for pd http api

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 13, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 13, 2022
@lcwangchao
Copy link
Collaborator Author

/run-monitor-test

@sre-bot
Copy link
Contributor

sre-bot commented Apr 13, 2022

Visit the grafana server at: http://172.16.5.5:31003, it will last for 5 hours

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels Apr 13, 2022
@lcwangchao
Copy link
Collaborator Author

/run-monitor-test

@lcwangchao
Copy link
Collaborator Author

/run-monitor-test

@lcwangchao
Copy link
Collaborator Author

/run-monitor-test

@sre-bot
Copy link
Contributor

sre-bot commented Apr 13, 2022

Visit the grafana server at: http://172.16.5.5:32683, it will last for 5 hours

@sre-bot
Copy link
Contributor

sre-bot commented Apr 13, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/39fdf034886c647bdf584228f319577bc47dd9d7

@lcwangchao
Copy link
Collaborator Author

/run-monitor-test

@sre-bot
Copy link
Contributor

sre-bot commented Apr 13, 2022

Visit the grafana server at: http://172.16.5.5:32033, it will last for 5 hours

@lcwangchao
Copy link
Collaborator Author

/run-mysql-test
/run-monitor-test

@sre-bot
Copy link
Contributor

sre-bot commented Apr 14, 2022

Visit the grafana server at: http://172.16.5.5:31881, it will last for 5 hours

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 14, 2022
rleungx
rleungx reviewed Apr 14, 2022
View reviewed changes
metrics/server.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 14, 2022
@lcwangchao
Copy link
Collaborator Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2b2d69f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 14, 2022
@lcwangchao
Copy link
Collaborator Author

/run-mysql-test

@ti-chi-bot ti-chi-bot merged commit 45e48b6 into pingcap:master Apr 14, 2022
@lcwangchao lcwangchao deleted the pd_http_api_grafana branch April 14, 2022 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rleungx rleungx rleungx approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

@wjhuang2016 wjhuang2016 Awaiting requested review from wjhuang2016

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lcwangchao @ti-chi-bot @sre-bot @hawkingrei @rleungx