*: using EscapeSQL to enhance SQL formatting in dumping & lightning #33951
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #33950
Problem Summary:
Due to the lack of support for escape functions in the golang standard library (database/sql: missing escape functions #18478), formatting functions have to be used in dumplings and lightning to splicing fields such as schema, table name, column name, etc., which will bring security risks.
What is changed and how it works?
The TiDB kernel implements some utility functions to handle internal SQL calls in secure. We can use the tool function EscapeSQL implemented by the TiDB kernel to escape fields such as schema, table name or column name, to eliminate the hidden dangers of current SQL formatting.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.