Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: refactor the cost implementation for Table/IndexReader/Scan, IndexLookup, Proj and Sel #34091

Merged
merged 15 commits into from
Apr 21, 2022
Merged

planner: refactor the cost implementation for Table/IndexReader/Scan, IndexLookup, Proj and Sel #34091

merged 15 commits into from
Apr 21, 2022

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Apr 19, 2022

What problem does this PR solve?

Issue Number: ref #33945

Problem Summary: planner: refactor the cost implementation for Table/IndexReader/Scan, IndexLookup, Proj and Sel

What is changed and how it works?

No logical change, just refactoring. Refactor the cost implementation for these operators: Table/IndexReader/Scan, IndexLookup, Proj and Sel.
Please see #33945 for more details.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@qw4990 qw4990 added type/enhancement The issue or PR belongs to an enhancement. sig/planner SIG: Planner labels Apr 19, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 19, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • time-and-fate
  • xuyifangreeneyes

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 19, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Apr 19, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/d8ead412c0be1f2981230362e898dcad40e66518

winoros
winoros reviewed Apr 19, 2022
View reviewed changes
planner/core/plan_cost.go Show resolved Hide resolved
planner/core/plan_cost.go
return 0, err
}
p.planCost = childCost
p.planCost += p.GetCost(p.StatsCount()) // projection cost
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't ban the GetCost here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, Operator.GetCost is used to calculate the current operator's cost, which can be re-used directly in the new cost interface as well.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 20, 2022
xuyifangreeneyes
xuyifangreeneyes reviewed Apr 21, 2022
View reviewed changes
planner/core/plan_cost.go Outdated
// consider concurrency
p.planCost /= float64(p.ctx.GetSessionVars().DistSQLScanConcurrency())

// lookup-cost(table-size seek cost)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we miss table-side seek cost here?

tidb/planner/core/task.go

Lines 1076 to 1081 in 5ba2adb

switch ts.StoreType {
case kv.TiKV:
t.cst += float64(len(ts.Ranges)) * sessVars.GetSeekFactor(ts.Table)
case kv.TiFlash:
t.cst += float64(len(ts.Ranges)) * float64(len(ts.Columns)) * sessVars.GetSeekFactor(ts.Table)
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

xuyifangreeneyes
xuyifangreeneyes approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@xuyifangreeneyes xuyifangreeneyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Besides, GetPlanCost and GetCost look so similar. Maybe we should rename one of the two to distinguish.

planner/core/plan_cost.go Outdated Show resolved Hide resolved
planner/core/plan_cost.go Outdated Show resolved Hide resolved
planner/core/plan_cost_test.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 21, 2022
@qw4990
Copy link
Contributor Author

qw4990 commented Apr 21, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d8ead41

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 21, 2022
@ti-chi-bot ti-chi-bot merged commit a798e78 into pingcap:master Apr 21, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Apr 21, 2022

TiDB MergeCI notify

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test 🟢 all 11 tests passed 10 min Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 9 min 12 sec Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 12 tests passed 8 min 51 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 8 min 41 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 6 min 51 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 42 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 41 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 5 min 11 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@xuyifangreeneyes xuyifangreeneyes mentioned this pull request Apr 23, 2022
Merged
12 tasks
espresso98 pushed a commit to espresso98/tidb that referenced this pull request Apr 25, 2022
@qw4990 @espresso98
planner: refactor the cost implementation for Table/IndexReader/Scan,…
1544a03 
… IndexLookup, Proj and Sel (pingcap#34091)

ref pingcap#33945
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros left review comments

@xuyifangreeneyes xuyifangreeneyes xuyifangreeneyes approved these changes

@time-and-fate time-and-fate time-and-fate approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@qw4990 @ti-chi-bot @sre-bot @winoros @time-and-fate @xuyifangreeneyes