executor: flush statement should trigger implicit commit (#34134) #34189
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #34134 to release-5.4
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/34189
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #34180
See https://github.com/pingcap/enterprise-plugin/issues/68
Problem Summary:
What is changed and how it works?
Let flush statement commit the current transaction.
After deleting the record from
mysql.tidb_audit_table_access
, the audit log plugin still working,that's because
flush tidb plugins audit;
doen't see the uncommitteddelete
statement.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.