Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning: fix auto_increment out-of-range error (#34146) #34336

Closed
wants to merge 1 commit into from
Closed

lightning: fix auto_increment out-of-range error (#34146) #34336

wants to merge 1 commit into from

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Apr 29, 2022 •
edited
Loading

cherry-pick #34146 to release-6.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/34336

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/34336:release-6.0-56179411707c

What problem does this PR solve?

Issue Number: close #27937

Problem Summary:

What is changed and how it works?

  • Change AlterAutoIncrement's parameter to uint64 whose maximum is larger than BIGINT.
  • Throw warning and return immediately while incr is larger than math.MaxInt64 (i.e. maximum of BIGINT)

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 29, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • D3Hunter

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 29, 2022
@ti-srebot ti-srebot added component/lightning This issue is related to Lightning of TiDB. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/6.0-cherry-pick labels Apr 29, 2022
@ti-srebot ti-srebot mentioned this pull request Apr 29, 2022
Merged
12 tasks
@buchuitoudegou
Copy link
Contributor

/run-integration-br-test

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 29, 2022
@buchuitoudegou
Copy link
Contributor

/run-integration-br-test

@buchuitoudegou
Copy link
Contributor

/run-unit-test

@sre-bot
Copy link
Contributor

sre-bot commented Apr 29, 2022

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/dd7068b7ee45b429e9d20be21738b3dcddc88081

@buchuitoudegou
Copy link
Contributor

/run-integration-br-test

7 similar comments
@buchuitoudegou
Copy link
Contributor

/run-integration-br-test

@buchuitoudegou
Copy link
Contributor

/run-integration-br-test

@buchuitoudegou
Copy link
Contributor

/run-integration-br-test

@buchuitoudegou
Copy link
Contributor

/run-integration-br-test

@buchuitoudegou
Copy link
Contributor

/run-integration-br-test

@buchuitoudegou
Copy link
Contributor

/run-integration-br-test

@buchuitoudegou
Copy link
Contributor

/run-integration-br-test

@xhebox
Copy link
Contributor

xhebox commented Aug 30, 2022

closed for DMR version

@xhebox xhebox closed this Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@D3Hunter D3Hunter D3Hunter approved these changes

@glorv glorv Awaiting requested review from glorv

@sleepymole sleepymole Awaiting requested review from sleepymole

Assignees

@buchuitoudegou buchuitoudegou

Labels
component/lightning This issue is related to Lightning of TiDB. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1. type/6.0-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ti-srebot @ti-chi-bot @buchuitoudegou @sre-bot @xhebox @D3Hunter