Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: plan cache always check scheme valid in RC isolation level #34523

Merged
merged 6 commits into from
May 13, 2022
Merged

planner: plan cache always check scheme valid in RC isolation level #34523

merged 6 commits into from
May 13, 2022

Conversation

you06
Copy link
Contributor

@you06 you06 commented May 10, 2022

Signed-off-by: you06 [email protected]

What problem does this PR solve?

Issue Number: close #34447

Problem Summary:

What is changed and how it works?

Plan cache always checks if the schema is stale in the RC isolation level because it should guarantee the index still exist in the latest schema.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 10, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lcwangchao
  • qw4990

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 10, 2022
lcwangchao
lcwangchao reviewed May 10, 2022
View reviewed changes
planner/optimize.go
if preparedObj, ok := preparedPointer.(*core.CachedPrepareStmt); ok && preparedObj.ForUpdateRead {
// RC isolation level or statement with for-update read need to check if the schema is changed
// before use the cached plan.
checkSchema := vars.IsIsolation(ast.ReadCommitted)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should prepare/execute in binary protocol be considerate too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the schema update is in OptimizePreparedPlan now, this function will be called by both text and binary protocol.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, here is the code path:
image

@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 10, 2022
@sre-bot
Copy link
Contributor

sre-bot commented May 11, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/ea4d75bd03da79c13c67cc1486532cc8fe6fffae

@you06
Copy link
Contributor Author

you06 commented May 11, 2022

This fix handles the prepared statements which use the latest schema in OptimizePreparedPlan. However, it updates the schema in a tricky way, the schema is changed in OptimizePreparedPlan, to guarantee the plan optimization and execution using the same schema, this fix syncs the schema before building executors.

@you06
Copy link
Contributor Author

you06 commented May 11, 2022

/run-mysql-test

@you06
Copy link
Contributor Author

you06 commented May 11, 2022

@qw4990 PTAL

@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 12, 2022
@you06
always check scheme valid in rc mode
a905a27 
Signed-off-by: you06 <[email protected]>

fix bug

Signed-off-by: you06 <[email protected]>

unify the handling of rc read in plan cache for text & binary protocol

Signed-off-by: you06 <[email protected]>

satisfy assertion

Signed-off-by: you06 <[email protected]>

sort imports & fix check

Signed-off-by: you06 <[email protected]>

fix lint

Signed-off-by: you06 <[email protected]>

do not update schema when optimizing

Signed-off-by: you06 <[email protected]>

fix test

Signed-off-by: you06 <[email protected]>
@you06
Copy link
Contributor Author

you06 commented May 12, 2022

/run-mysql-test

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 12, 2022
@you06
Copy link
Contributor Author

you06 commented May 12, 2022

@lcwangchao I change this patch by updating the latest schema for the required statements before optimizing, PTAL again.

@you06
Copy link
Contributor Author

you06 commented May 12, 2022

/run-mysql-test

@lcwangchao
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ea4d75b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 13, 2022
@ti-chi-bot ti-chi-bot merged commit 0703a64 into pingcap:master May 13, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request May 13, 2022
@you06 @ti-srebot
cherry pick pingcap#34523 to release-4.0
0f673c6 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request May 13, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #34614

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request May 13, 2022
@you06 @ti-srebot
cherry pick pingcap#34523 to release-5.0
676a8e9 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request May 13, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #34615

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request May 13, 2022
@you06 @ti-srebot
cherry pick pingcap#34523 to release-5.1
78fdcc3 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request May 13, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #34616

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request May 13, 2022
@you06 @ti-srebot
cherry pick pingcap#34523 to release-5.2
44312f2 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request May 13, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #34617

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request May 13, 2022
@you06 @ti-srebot
cherry pick pingcap#34523 to release-5.3
c093c60 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request May 13, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #34618

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request May 13, 2022
@you06 @ti-srebot
cherry pick pingcap#34523 to release-5.4
b5b8c64 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request May 13, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #34619

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request May 13, 2022
@you06 @ti-srebot
cherry pick pingcap#34523 to release-6.0
1bc4305 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request May 13, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.0 in PR #34620

@sre-bot
Copy link
Contributor

sre-bot commented May 13, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/common-test 🟥 failed 1, success 11, total 12 5 min 49 sec New failing
idc-jenkins-ci/integration-cdc-test 🟢 all 34 tests passed 34 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 13 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 11 tests passed 10 min Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 6 min 45 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 50 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 41 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 58 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 35 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

ti-chi-bot pushed a commit that referenced this pull request Jun 14, 2022
@ti-srebot
planner: plan cache always check scheme valid in RC isolation level (#…
76a4351 
…34523) (#34618)

close #34447
ti-chi-bot pushed a commit that referenced this pull request Sep 16, 2022
@ti-srebot
planner: plan cache always check scheme valid in RC isolation level (#…
7ef14d0 
…34523) (#34619)

close #34447
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcwangchao lcwangchao lcwangchao approved these changes

@qw4990 qw4990 qw4990 approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

query result is incorrect when execute prepared statement in RC isolation with plan cache enabled
6 participants
@you06 @ti-chi-bot @sre-bot @lcwangchao @ti-srebot @qw4990