-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: global stats consistency for dynamic prune #34695
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/3b562a7912cd85b00ab33faaab4cadfb26de3d4f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found that there exists lots of duplciated assertion code in unit test, can we extract it as common function?
Co-authored-by: Song Gao <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM
Not too many in common, prefer to keep the flexibility. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: bbc8b81
|
TiDB MergeCI notify🔴 Bad News! [1] CI still failing after this pr merged.
|
What problem does this PR solve?
Issue Number: close #34730
Problem Summary:
Refine the logic of analyze under dynamic prune mode, to avoid inconsistency between partition stats and global stats.
In static mode, we may have different column settings and different persisted analyze options for partitions. That's the root cause of inconsistency.
What is changed and how it works?
BTW:
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.