-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
variable: revise TiDBStatsCacheMemQuota settting code #34762
Conversation
Signed-off-by: yisaer <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/bbe76069f244cbf22203b94e627a0cdda7bcac35 |
Nice work! We should consider using this same trick in the other cases where we need |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: b6e189f
|
/run-mysql-test |
2 similar comments
/run-mysql-test |
/run-mysql-test |
TiDB MergeCI notify🔴 Bad News! [1] CI still failing after this pr merged.
|
Signed-off-by: yisaer [email protected]
What problem does this PR solve?
Issue Number: ref #34052
Problem Summary:
What is changed and how it works?
revise TiDBStatsCacheMemQuota settting code by moving code into
SetGlobal
Check List
Tests
I manually tested
set global tidb_stats_cache_mem_quota
, it still workRelease note
Please refer to Release Notes Language Style Guide to write a quality release note.