-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shenli/wrap data #349
Merged
Merged
Shenli/wrap data #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can not infer result field type from nil.
@@ -111,3 +111,13 @@ func (ft *FieldType) String() string { | |||
|
|||
return strings.Join(strs, " ") | |||
} | |||
|
|||
// DataItem is wrapped data with type info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is wrapped -> warps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrapped is an adj.
PTAL @qiuyesuifeng |
YuJuncen
pushed a commit
to YuJuncen/tidb
that referenced
this pull request
Apr 23, 2021
YuJuncen
pushed a commit
to YuJuncen/tidb
that referenced
this pull request
Apr 23, 2021
… common handle (pingcap#349) * update for common handle * update * remove parentless
xhebox
pushed a commit
to xhebox/tidb
that referenced
this pull request
Sep 28, 2021
'SHOW TABLE table_name [INDEX] [index_name] REGIONS'
xhebox
pushed a commit
to xhebox/tidb
that referenced
this pull request
Oct 8, 2021
'SHOW TABLE table_name [INDEX] [index_name] REGIONS'
ti-chi-bot
pushed a commit
that referenced
this pull request
Oct 9, 2021
'SHOW TABLE table_name [INDEX] [index_name] REGIONS'
iosmanthus
pushed a commit
to iosmanthus/tidb
that referenced
this pull request
May 11, 2023
* mod: upgrade the pd client Signed-off-by: nolouch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrap data with FieldType for cast function.
Fix #325
In the next pr, I will change the parameters of compare/cast/convert from raw type to DataItem.