Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distsql,executor: using paging protocol for all coprocessor requests #35068

Merged
merged 3 commits into from
Jun 1, 2022

Conversation

tiancaiamao
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #35067

Problem Summary:

What is changed and how it works?

Set paging when building the distsql request, for all executors.
In the past we only do that for IndexLoopUp.

There is still a switch tidb_enable_paging to control the behavior. The default value is still false.
I want coprocessor paging to be the default implementation for all cases, but let's do it step by step.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
mysql> select count(*) from sbtest1;
+----------+
| count(*) |
+----------+
|  7425577 |
+----------+
1 row in set (0.44 sec)

Use this PR, and then set @@tidb_enable_paging=1 to see the difference:

mysql -h 127.0.0.1 -u root -P 4000  -e 'select * from  (select * from sbtest.sbtest1 union all select * from sbtest.sbtest2 union all select * from sbtest.sbtest3 union all select * from sbtest.sbtest4 union all select * from sbtest.sbtest5 union all select * from sbtest.sbtest6 union all select * from sbtest.sbtest7 union all select * from sbtest.sbtest8)' > /dev/null
mysql -h 127.0.0.1 -u root -P 4000  -e 'set @@tidb_enable_paging=1; select * from  (select * from sbtest.sbtest1 union all select * from sbtest.sbtest2 union all select * from sbtest.sbtest3 union all select * from sbtest.sbtest4 union all select * from sbtest.sbtest5 union all select * from sbtest.sbtest6 union all select * from sbtest.sbtest7 union all select * from sbtest.sbtest8)' > /dev/null

Before vs After

image

It reduce a lot memory footprint ... although we need to handle channel capacity #34849 to completely solve the problem.

  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 31, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • XuHuaiyu
  • wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels May 31, 2022
@tiancaiamao tiancaiamao marked this pull request as ready for review May 31, 2022 07:07
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels May 31, 2022
@sre-bot
Copy link
Contributor

sre-bot commented May 31, 2022

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 31, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 1, 2022
@tiancaiamao
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5eb7151

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 1, 2022
@ti-chi-bot ti-chi-bot merged commit c8468a7 into pingcap:master Jun 1, 2022
@tiancaiamao tiancaiamao deleted the paging-for-all branch June 1, 2022 03:11
@sre-bot
Copy link
Contributor

sre-bot commented Jun 1, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [1] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test ✅ all 11 tests passed 13 min Fixed
idc-jenkins-ci/integration-cdc-test 🟢 all 35 tests passed 28 min Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 7 min 33 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 6 min 22 sec Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 12 tests passed 6 min 14 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 52 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 33 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 14 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 2 min 53 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make coprocessor paging protocol as a general one
5 participants