-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
distsql,executor: using paging protocol for all coprocessor requests #35068
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/1d0cc0e321f871c0168f0eb2e0f355fd0b0b850e |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 5eb7151
|
TiDB MergeCI notify✅ Well Done! New fixed [1] after this pr merged.
|
What problem does this PR solve?
Issue Number: close #35067
Problem Summary:
What is changed and how it works?
Set paging when building the distsql request, for all executors.
In the past we only do that for
IndexLoopUp
.There is still a switch
tidb_enable_paging
to control the behavior. The default value is stillfalse
.I want coprocessor paging to be the default implementation for all cases, but let's do it step by step.
Check List
Tests
Use this PR, and then
set @@tidb_enable_paging=1
to see the difference:Before vs After
It reduce a lot memory footprint ... although we need to handle channel capacity #34849 to completely solve the problem.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.