*: enable nogo to use fast incremental linter #35344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
|
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/9ff0d009646da877e0a2f629723e37c76fbee05a |
hawkingrei
force-pushed
the
enable_nogo
branch
3 times, most recently
from
9a35333
to
ca261a9
Compare
ti-chi-bot
added
size/XL
ti-chi-bot
added
size/M
|
/run-build |
ti-chi-bot
added
size/L
|
/run-build |
|
/run-unit-test |
ti-chi-bot
added
size/XL
hawkingrei
force-pushed
the
enable_nogo
branch
2 times, most recently
from
6271b25
to
4be565b
Compare
ti-chi-bot
added
size/L
ti-chi-bot
added
size/XL
Signed-off-by: Weizhen Wang <[email protected]>
32 tasks
tangenta
approved these changes
Jun 16, 2022
|
/run-all-tests |
tisonkun
approved these changes
Jun 17, 2022
ti-chi-bot
added
status/LGT2
|
/run-all-tests |
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 955b4d0
|
ti-chi-bot
added
the
status/can-merge
|
/run-unit-test |
|
/run-mysql-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #35345
Problem Summary:
What is changed and how it works?
We spend too much time on the linter. we can use a fast incremental linter by enabling nogo to save time. It uses bazel's remote cache to check the code linter when the code has been changed.
First we use Bazel nogo to replace with govet
Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.