update field name #354
Merged
update field name #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -144,12 +144,12 @@ func (*testResultFieldSuite) TestMain(c *C) { | |||
|
|
|||
| // For GetFieldIndex | |||
| f1 := &field.Field{ | |||
| Expr: &expression.Ident{CIStr: model.NewCIStr("c1")}, | |||
| Name: "a", | |||
| Expr: &expression.Ident{CIStr: model.NewCIStr("c1")}, | |||
There was a problem hiding this comment.
Why use '&' herer but does not use '&' in the above test file?
There was a problem hiding this comment.
I don't see any other place not using "&" for expression.Ident.
There was a problem hiding this comment.
Value is kind of weird, Maybe we should change its function to use pointer.
Expr: expression.Value{Val: "c1+1"},
There was a problem hiding this comment.
+1, all expressions use pointer is better.
|
LGTM |
| name = expr.String() | ||
| } | ||
| $$ = &field.Field{Expr: expr, Name: name} | ||
| $$ = &field.Field{Expr: expr, AsName: name} |
There was a problem hiding this comment.
How about
$$ = &field.Field{
Expr: expression.Expr($1),
AsName: $2.(string)
}
seems needless to define variables.
There was a problem hiding this comment.
Em, seems no big different. :-)
|
LGTM |
YuJuncen
pushed a commit
to YuJuncen/tidb
that referenced
this pull request
Apr 23, 2021
Co-authored-by: kennytm <[email protected]>
okJiang
pushed a commit
to okJiang/tidb
that referenced
this pull request
Oct 19, 2021
iosmanthus
added a commit
to iosmanthus/tidb
that referenced
this pull request
May 11, 2023
rleungx
pushed a commit
to rleungx/tidb
that referenced
this pull request
Feb 26, 2024
…gcap#536) * fix tiflash rules constraints by introducing `TiFlashConstraints` in config (pingcap#354) Signed-off-by: iosmanthus <[email protected]> * introduce tiflash replica min count (pingcap#371) Co-authored-by: zzm <[email protected]> Signed-off-by: iosmanthus <[email protected]> * auto fix missing tiflash placment rules (pingcap#364) Signed-off-by: iosmanthus <[email protected]> * fix noop for setting tiflash replicas to 0 Signed-off-by: iosmanthus <[email protected]> --------- Signed-off-by: iosmanthus <[email protected]> Co-authored-by: zzm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use as name explicitly. Old code uses as name for field name, if has not, uses origin expression string instead. e,g,
select 1 as a, we will use "a" as the field name,select 1, we will use "1" as the field name.This mechanism is not proper for later field name handing in group by, order by or other clauses. e.g,
select t.c as "t.c" from t, using the old way we cannot know "t.c" is an alia name or just expression representation. So now theGetField*function in field package is complex and confused.I think we will use AsName in field struct explicitly, we will check AsName to see whether a field has an alias name or not, if no alias name, we can try to use expression representation then.