Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store/copr: fix tiflash integration test by disable paging on tiflash #35674

Merged
merged 5 commits into from
Jun 24, 2022
Merged

store/copr: fix tiflash integration test by disable paging on tiflash #35674

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6bdd0d7
store/copr: fix tiflash integration test after enable coprocessor paging
tiancaiamao Jun 23, 2022
65e917f
address comment
tiancaiamao Jun 23, 2022
40a5b2a
need to fix mocktikv
tiancaiamao Jun 24, 2022
c0cd3e0
Merge branch 'master' into tiflash-paging
ti-chi-bot Jun 24, 2022
327c4cd
Merge branch 'master' into tiflash-paging
ti-chi-bot Jun 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion store/copr/coprocessor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -860,7 +860,9 @@ func (worker *copIteratorWorker) handleCopPagingResult(bo *Backoffer, rpcCtx *ti
pagingRange := resp.pbResp.Range
// only paging requests need to calculate the next ranges
if pagingRange == nil {
return nil, errors.New("lastRange in paging should not be nil")
// If the storage engine doesn't support paging protocol, it should have return all the region data.
// So we finish here.
return nil, nil
}
// calculate next ranges and grow the paging size
task.ranges = worker.calculateRemain(task.ranges, pagingRange, worker.req.Desc)
Expand Down