Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: enable gci #35823

Merged
merged 2 commits into from
Jul 4, 2022
Merged

*: enable gci #35823

merged 2 commits into from
Jul 4, 2022

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Jun 29, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #35345

Problem Summary:

What is changed and how it works?

use gci to replace with goimports because goimports have many problems in the nogo

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 29, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ngaut
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 29, 2022
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 29, 2022
@hawkingrei hawkingrei mentioned this pull request Jun 29, 2022
Closed
7 tasks
@hawkingrei
Copy link
Member Author

/run-unit-test

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 29, 2022
@hawkingrei hawkingrei added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jun 30, 2022
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 2, 2022
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 3, 2022
@hawkingrei hawkingrei force-pushed the update_fix_build branch 2 times, most recently from 74a963e to 3d94c20 Compare July 3, 2022 12:36
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 3, 2022
@hawkingrei
Copy link
Member Author

/run-unit-test

1 similar comment
@hawkingrei
Copy link
Member Author

/run-unit-test

@sre-bot
Copy link
Contributor

sre-bot commented Jul 3, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/05e3c25fb9a165a68968abc966365d144d7a7d9a

@hawkingrei hawkingrei removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 3, 2022
@hawkingrei hawkingrei changed the title *: enable goimports *: enable gci Jul 3, 2022
@hawkingrei hawkingrei requested a review from tisonkun July 3, 2022 15:01
@hawkingrei
Copy link
Member Author

The order of go import in the tidb is so chaos.

@hawkingrei hawkingrei requested a review from tangenta July 3, 2022 15:02
@ti-chi-bot
Copy link
Member

@leiysky: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

tisonkun
tisonkun reviewed Jul 3, 2022
View reviewed changes
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good. One suggestion inline. Also you may remember to update code style section on TiDB Dev Guide https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/code-style-and-quality-guide.html.

br/pkg/lightning/backend/kv/sql2kv.go
"github.com/pingcap/tidb/parser/mysql"
"github.com/pingcap/tidb/parser/mysql" //nolint:goimports
// Import tidb/planner/core to initialize expression.RewriteAstExpr
_ "github.com/pingcap/tidb/planner/core"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if separate init only import-s?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if remove //nolint:goimports

[2022-07-03T15:57:37.755Z] br/pkg/lightning/backend/kv/sql2kv.go:36: File is not `goimports`-ed (goimports)

[2022-07-03T15:57:37.755Z] 	"github.com/pingcap/tidb/parser/mysql"

I don't know what is it.

@hawkingrei
Copy link
Member Author

/run-unit-test

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 4, 2022
@tisonkun
Copy link
Contributor

tisonkun commented Jul 4, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a472abe

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 4, 2022
@hawkingrei
Copy link
Member Author

/run-build

@hawkingrei
Copy link
Member Author

/run-mysql-test

@ti-chi-bot ti-chi-bot merged commit e50b943 into pingcap:master Jul 4, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 4, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test 🟥 failed 1, success 10, total 11 28 min New failing
idc-jenkins-ci/integration-cdc-test ✅ all 35 tests passed 31 min Fixed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 1 hr 0 min Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 18 min Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 17 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 12 tests passed 16 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 15 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 13 min Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 13 min Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@hawkingrei hawkingrei deleted the update_fix_build branch July 16, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisonkun tisonkun tisonkun left review comments

@tangenta tangenta tangenta approved these changes

@leiysky leiysky leiysky approved these changes

@xiongjiwei xiongjiwei xiongjiwei approved these changes

@ngaut ngaut ngaut approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@hawkingrei @ti-chi-bot @sre-bot @tisonkun @ngaut @xiongjiwei @leiysky @tangenta