Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

telemetry: Initialize telemetry asynchronously #35898

Merged
merged 6 commits into from
Jul 6, 2022
Merged

telemetry: Initialize telemetry asynchronously #35898

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b65b7cf
Initialize telemetry asynchronously
sunxiaoguang Jul 3, 2022
e1acb48
Move comments out of go call
sunxiaoguang Jul 3, 2022
ea3ab4c
Merge branch 'master' into async_telemetry
hawkingrei Jul 4, 2022
3c2719f
Merge branch 'master' into async_telemetry
sunxiaoguang Jul 6, 2022
2c5a55d
Merge branch 'master' into async_telemetry
ti-chi-bot Jul 6, 2022
57a24cd
Merge branch 'master' into async_telemetry
ti-chi-bot Jul 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions session/session.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2879,8 +2879,10 @@ func BootstrapSession(store kv.Storage) (*domain.Domain, error) {
if dom.GetEtcdClient() != nil {
// We only want telemetry data in production-like clusters. When TiDB is deployed over other engines,
// for example, unistore engine (used for local tests), we just skip it. Its etcd client is nil.
dom.TelemetryReportLoop(ses[5])
dom.TelemetryRotateSubWindowLoop(ses[5])
go func() {
dom.TelemetryReportLoop(ses[5])
dom.TelemetryRotateSubWindowLoop(ses[5])
}()
}

// A sub context for update table stats, and other contexts for concurrent stats loading.
Expand Down