Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: enable revive #35970

Merged
merged 57 commits into from
Jul 15, 2022
Merged

*: enable revive #35970

merged 57 commits into from
Jul 15, 2022

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Jul 5, 2022 •
edited
Loading

Signed-off-by: Weizhen Wang [email protected]

What problem does this PR solve?

Issue Number: ref #35345

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 5, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lance6716
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 5, 2022
@hawkingrei hawkingrei mentioned this pull request Jul 6, 2022
Merged
2 tasks
@hawkingrei hawkingrei force-pushed the enable_revive branch 3 times, most recently from b803d8c to b5104ff Compare July 6, 2022 11:53
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 6, 2022
@hawkingrei hawkingrei force-pushed the enable_revive branch 4 times, most recently from 02b779c to 40916b4 Compare July 7, 2022 13:57
@sre-bot
Copy link
Contributor

sre-bot commented Jul 7, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/1840a032dcccc73493c46f464467068ff9933e35

@hawkingrei hawkingrei mentioned this pull request Jul 7, 2022
Closed
7 tasks
@hawkingrei
Copy link
Member Author

revive find too many problems. so that it is too hard for me to fix all of them. I will invite the person to fix them.

@hawkingrei
Copy link
Member Author

/run-unit-test

@hawkingrei
Copy link
Member Author

/run-all-tests

@tisonkun
Copy link
Contributor

tisonkun commented Jul 8, 2022 •
edited
Loading

/uncc

This patch is incomplete. Also, please describe a bit what a "revive" linter does - it's unintuitive.

@ti-chi-bot ti-chi-bot removed the request for review from tisonkun July 8, 2022 01:41
@hawkingrei hawkingrei force-pushed the enable_revive branch 2 times, most recently from a19b762 to 8b1949b Compare July 8, 2022 02:41
hawkingrei and others added 14 commits July 15, 2022 15:14
@hawkingrei
refactor
d4b9741 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei @tangenta
Update parser/charset/charset.go
b51194e 
Co-authored-by: tangenta <[email protected]>
@hawkingrei @tangenta
Update parser/charset/charset.go
a901013 
Co-authored-by: tangenta <[email protected]>
@hawkingrei @tangenta
Update parser/yy_parser.go
1800457 
Co-authored-by: tangenta <[email protected]>
@hawkingrei @tangenta
Update parser/format/format.go
ec3ce91 
Co-authored-by: tangenta <[email protected]>
@hawkingrei
improve log
5b1dcb9
@hawkingrei
refactor
065dc53 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
refactor
358b669 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
refactor
bc965ac 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
refactor
524d8c7 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
refactor
45c70a5 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
refactor
4406879 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
refactor
1c91921 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
refactor
20f91e3 
Signed-off-by: Weizhen Wang <[email protected]>
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jul 15, 2022
@hawkingrei
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 20f91e3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 15, 2022
@hawkingrei
Copy link
Member Author

/run-build

@hawkingrei
refactor
393580e 
Signed-off-by: Weizhen Wang <[email protected]>
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jul 15, 2022
@hawkingrei
refactor
5b335f9 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5b335f9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 15, 2022
@ti-chi-bot
Copy link
Member

@hawkingrei: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 911e7cc into pingcap:master Jul 15, 2022
@hawkingrei hawkingrei deleted the enable_revive branch July 15, 2022 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disksing disksing disksing left review comments

@tangenta tangenta tangenta approved these changes

@lance6716 lance6716 lance6716 approved these changes

@xiongjiwei xiongjiwei Awaiting requested review from xiongjiwei

@Defined2014 Defined2014 Awaiting requested review from Defined2014

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@hawkingrei @ti-chi-bot @sre-bot @tisonkun @disksing @lance6716 @tangenta