support like escape #360
Merged
support like escape #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| i-- | ||
| c = '\\' | ||
| c = escape | ||
| } | ||
| } |
There was a problem hiding this comment.
I just use the old code here, which just seems using the origin escape character directly.
I have added a comment that we will add more tests later.
There was a problem hiding this comment.
If the escape is the last character in the pattern, the match type would be exact match.
|
LGTM |
1 similar comment
|
LGTM |
iosmanthus
pushed a commit
to iosmanthus/tidb
that referenced
this pull request
May 11, 2023
Signed-off-by: disksing <[email protected]>
rleungx
pushed a commit
to rleungx/tidb
that referenced
this pull request
Feb 26, 2024
* standby for 7.1 Signed-off-by: zeminzhou <[email protected]> * standby for 7.1 Signed-off-by: zeminzhou <[email protected]> * update standby condition (pingcap#360) Signed-off-by: disksing <[email protected]> * make check Signed-off-by: zeminzhou <[email protected]> * make check Signed-off-by: zeminzhou <[email protected]> * Update standby/standby.go Co-authored-by: tidbcloud-bot <[email protected]> * Update standby/idle_watcher.go Co-authored-by: tidbcloud-bot <[email protected]> * make check Signed-off-by: zeminzhou <[email protected]> --------- Signed-off-by: zeminzhou <[email protected]> Signed-off-by: disksing <[email protected]> Co-authored-by: disksing <[email protected]> Co-authored-by: tidbcloud-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #344