Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store/mockstore/unistore: fix several issues of coprocessor paging in unistore #36147

Merged
merged 5 commits into from
Jul 13, 2022

Conversation

tiancaiamao
Copy link
Contributor

@tiancaiamao tiancaiamao commented Jul 12, 2022

What problem does this PR solve?

Issue Number: close #36145

Problem Summary:

What is changed and how it works?

Fix several bugs.

  1. I mistakenly use break ... which should be return
for {
    switch {
        case xxx:
-              break
+             return   // To break the loop, it should be "return"
    }
}
  1. To store the key/value in a iterator function, deep copy should be used
dbReader.Scan(keyRange, func(key, value []byte) {
    // key value is borrowed from dbReader 
    // To save the key/value for outside usage, a deep copy is necessary
})
  1. When paging size < topN limit count, the cop-pushed-down topN executor should degenerate to no operation.

Take this as example:

mysql> explain select a from trange use index(idx_a) where a > 84 order by a limit 400;
+-----------------------------+---------+-----------+------------------------------+-------------------------------------------------+
| id                          | estRows | task      | access object                | operator info                                   |
+-----------------------------+---------+-----------+------------------------------+-------------------------------------------------+
| TopN_8                      | 400.00  | root      |                              | test.trange.a, offset:0, count:400              |
| └─IndexReader_17            | 400.00  | root      | partition:all                | index:TopN_16                                   |
|   └─TopN_16                 | 400.00  | cop[tikv] |                              | test.trange.a, offset:0, count:400              |
|     └─IndexRangeScan_15     | 3333.33 | cop[tikv] | table:trange, index:idx_a(a) | range:(84,+inf], keep order:false, stats:pseudo |
+-----------------------------+---------+-----------+------------------------------+-------------------------------------------------+
4 rows in set (0.00 sec)

CopDAG: TopN -> IndexScan

IndexScan rows = 1000
TopN count = 400
Paging size = 64

If TopN calculate the top 400, it consume the whole IndexScan rows ...
it returns 64 rows, but it can't determine the corresponding key range!

Check List

Tests

  • Unit test

I found the bug when testing #36107
When @@tidb_min_paging_size is set, the current unit tests could cover the change.

  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 12, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • XuHuaiyu
  • wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 12, 2022
@tiancaiamao tiancaiamao marked this pull request as ready for review July 12, 2022 10:58
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 12, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 12, 2022

@tiancaiamao
Copy link
Contributor Author

/run-check_dev_2

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 13, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 13, 2022
@XuHuaiyu
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4a3a584

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 13, 2022
@tiancaiamao
Copy link
Contributor Author

/run-build

@tiancaiamao
Copy link
Contributor Author

/run-build
/run-mysql-test

@ti-chi-bot ti-chi-bot merged commit 8997604 into pingcap:master Jul 13, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 13, 2022

TiDB MergeCI notify

🔴 Bad News! [1] CI still failing after this pr merged.
These failed integration tests don't seem to be introduced by the current PR.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🔴 failed 1, success 35, total 36 27 min Existing failure
idc-jenkins-ci-tidb/integration-common-test 🟢 all 11 tests passed 26 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 12 tests passed 17 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 10 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 8 min 24 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 6 min 33 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 33 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 34 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 24 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@tiancaiamao tiancaiamao deleted the fix-topn-paging branch July 13, 2022 11:33
joycse06 added a commit to joycse06/tidb that referenced this pull request Jul 13, 2022
* master: (27 commits)
  executor: parallel cancel mpp query (pingcap#36161)
  store/copr: adjust the cop cache admission process time for paging (pingcap#36157)
  log-backup: get can restored global-checkpoint-ts when support v3 checkpoint advance (pingcap#36197)
  executor: optimize cursor read point get by reading through pessimistic lock cache (pingcap#36149)
  *: add tidb_min_paging_size system variable (pingcap#36107)
  planner: handle the expected row count for pushed-down selection in mpp (pingcap#36195)
  *: support show ddl jobs for sub-jobs (pingcap#36168)
  table-filter: optimize table pattern message and unit tests (pingcap#36160)
  domain: fix unstable test TestAbnormalSessionPool (pingcap#36154)
  executor: check the error returned by `handleNoDelay` (pingcap#36105)
  log-backup: fix checkpoint display (pingcap#36166)
  store/mockstore/unistore: fix several issues of coprocessor paging in unistore (pingcap#36147)
  test: refactor restart test (pingcap#36174)
  ddl: support rename index and columns for multi-schema change (pingcap#36148)
  test: remove meaningless test and update bazel (pingcap#36136)
  planner: Reduce verbosity of logging unknown system variables (pingcap#36013)
  metrics/grafana: bring back the plan cache miss panel (pingcap#36081)
  ddl: implement table granularity DDL for SchemaTracker (pingcap#36077)
  *: bazel use jdk 17 (pingcap#36070)
  telemetry: add reviewer rule (pingcap#36084)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

With small @@tidb_min_paging_size, coprocessor paging get wrong result with unistore
5 participants