Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log-backup: calculate global-checkpoint from pd written by tikv #36305

Merged
merged 16 commits into from
Jul 20, 2022
Merged

log-backup: calculate global-checkpoint from pd written by tikv #36305

merged 16 commits into from
Jul 20, 2022

Conversation

joccau
Copy link
Member

@joccau joccau commented Jul 19, 2022 •
edited
Loading

Signed-off-by: joccau [email protected]

What problem does this PR solve?

Issue Number: close #36246

Problem Summary:
The global checkpoint-ts got by command br log metadata from externStorage is smaller than the value got by command br log status from PD server in upstream-cluster.

What is changed and how it works?

  • The tikv-server need upload checkpoint-ts(has flushed into externStorage) to pd that can be query by br log status.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Manual test

  • br log status -u "x.x.x.x:2379"
    ● Total 1 Tasks.

#1 <
name: store-by-storeid
status: ● NORMAL
start: 2022-07-14 20:08:03.268 +0800 CST
end: 2090-11-18 22:07:45.624 +0800 CST
storage: s3://tmp/store-by-storeid/log1
speed(est.): 0.00 ops/s
checkpoint[global]: 2022-07-20 13:03:42.918 +0800 CST; gap=1m42s

  • br log metadata -s "xxxxxx"
    [2022/07/20 13:05:24.908 +08:00] [INFO] [collector.go:69] ["log metadata"] [log-min-ts=434582449885806593] [log-min-date="2022-07-14 20:08:03.268 +0800 CST"] [log-max-ts=434711671057416193] [log-max-date="2022-07-20 13:03:42.918 +0800 CST"]

  • Conclusion
    The global checkpoint-ts got by command br log metadata from externStorage is smaller than or equal to the value got by command br log status from PD server in upstream-cluster.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 19, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • Leavrth

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 19, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 19, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/783cb2108dff8a9ce4a1da5e23e8354dae6c7f62

@joccau
add test case
85bf318 
Signed-off-by: joccau <[email protected]>
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 20, 2022
@joccau
Copy link
Member Author

joccau commented Jul 20, 2022

/cc @YuJuncen @3pointer @Leavrth

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 20, 2022
3pointer
3pointer approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@3pointer 3pointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 20, 2022
@3pointer
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b13f71d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 20, 2022
@joccau
Copy link
Member Author

joccau commented Jul 20, 2022

/run-mysql-test

@3pointer
Copy link
Contributor

/run-mysql-test

@3pointer
Copy link
Contributor

/run-check_dev_2

1 similar comment
@joccau
Copy link
Member Author

joccau commented Jul 20, 2022

/run-check_dev_2

@3pointer
Copy link
Contributor

/rebuild

@3pointer
Copy link
Contributor

/run-check_dev_2

@joccau joccau changed the title log-backup: calcualte global-checkpoint from pd written by tikv log-backup: calculate global-checkpoint from pd written by tikv Jul 20, 2022
@joccau
Copy link
Member Author

joccau commented Jul 20, 2022

/run-unit-test

@3pointer
Copy link
Contributor

/run-mysql-tests

@3pointer
Copy link
Contributor

/run-unit-tests

@3pointer 3pointer merged commit 676ecab into pingcap:master Jul 20, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 20, 2022

TiDB MergeCI notify

🔴 Bad News! [2] CI still failing after this pr merged.
These failed integration tests don't seem to be introduced by the current PR.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🔴 failed 35, success 1, total 36 1 hr 11 min Existing failure
idc-jenkins-ci-tidb/integration-common-test 🔴 failed 2, success 9, total 11 49 min Existing failure
idc-jenkins-ci-tidb/common-test 🟢 all 12 tests passed 17 min Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 6 min 37 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 6 min 23 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 32 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 16 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 39 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 4 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leavrth Leavrth Leavrth approved these changes

@3pointer 3pointer 3pointer approved these changes

@YuJuncen YuJuncen Awaiting requested review from YuJuncen

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PiTR restore failed due to restored_ts > log backup range
5 participants
@joccau @ti-chi-bot @sre-bot @3pointer @Leavrth