planner: avoid change the type of the input of sum/avg

[windtalker]

Signed-off-by: xufei [email protected]

What problem does this PR solve?

Issue Number: close #36371

Problem Summary:

What is changed and how it works?

In #7860, it saved the return type of sum/avg to its input argument, this is actually a workaround as the review comments shows:

The only reason to do so is that baseAvgDecimal does not have the return type, however, after #30010, baseAvgDecimal do have the return type information, so we can use the return type information directly, and it makes no sense to save the return type in the input argument anymore.

This pr remove the related codes.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• XuHuaiyu
• wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[XuHuaiyu]

/run-integration-common-test
/run-common-test
/run-sqllogic-test
/run-mybatis-test
/run-tics-test

[sre-bot]

Please follow PR Title Format:

• pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

• *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

[XuHuaiyu]

/run-mysql-test tidb-test=pr/1895

[windtalker]

/run-mysql-test tidb-test=pr/1895

[windtalker]

/run-check_dev_2

[windtalker]

/run-mysql-test tidb-test=pr/1895

[windtalker]

/run-integration-common-test
/run-common-test
/run-sqllogic-test
/run-mybatis-test
/run-tics-test

[windtalker]

/run-unit-test

[sre-bot]

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/df95a77b35d9ae7b9c3ef55d45292399fa6819e3

[windtalker]

Also need to update the test reference in tidb-test repo: https://github.com/pingcap/tidb-test/pull/1895

[windtalker]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 3813b8c

[windtalker]

/run-mysql-test tidb-test=pr/1895

[sre-bot]

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name	Result	Duration	Compare with Parent commit
idc-jenkins-ci-tidb/common-test	🟥 failed 2, success 9, total 11	16 min	New failing
idc-jenkins-ci-tidb/integration-common-test	🔴 failed 9, success 8, total 17	18 min	Existing failure
idc-jenkins-ci/integration-cdc-test	🟢 all 36 tests passed	33 min	Existing passed
idc-jenkins-ci-tidb/integration-ddl-test	🟢 all 6 tests passed	8 min 22 sec	Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2	🟢 all 28 tests passed	8 min 12 sec	Existing passed
idc-jenkins-ci-tidb/tics-test	🟢 all 1 tests passed	7 min 11 sec	Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1	🟢 all 26 tests passed	6 min 43 sec	Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test	🟢 all 1 tests passed	4 min 3 sec	Existing passed
idc-jenkins-ci-tidb/mybatis-test	🟢 all 1 tests passed	3 min 16 sec	Existing passed
idc-jenkins-ci-tidb/plugin-test	🟢 build success, plugin test success	4min	Existing passed