Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: support cost detail framework #36641

Merged
merged 20 commits into from
Aug 3, 2022
Merged

planner: support cost detail framework #36641

merged 20 commits into from
Aug 3, 2022

Conversation

Yisaer
Copy link
Contributor

@Yisaer Yisaer commented Jul 28, 2022 •
edited
Loading

Signed-off-by: yisaer [email protected]

What problem does this PR solve?

Issue Number: ref #29661

Problem Summary:

What is changed and how it works?

Support cost detail framework

Check List

Tests

  • Unit test

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 28, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • time-and-fate

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 28, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 28, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/28b387f6a4c22cc8b10f7f6656470c1e4228cf77

@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 29, 2022
@Yisaer
add test
e0a83eb 
Signed-off-by: yisaer <[email protected]>
@Yisaer Yisaer marked this pull request as ready for review July 29, 2022 05:18
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 29, 2022
@Yisaer
fix lint
d1271b1 
Signed-off-by: yisaer <[email protected]>
@Yisaer
fix lint
9f5feb0 
Signed-off-by: yisaer <[email protected]>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 1, 2022
time-and-fate
time-and-fate reviewed Aug 2, 2022
View reviewed changes
planner/core/plan_cost_detail_test.go Outdated Show resolved Hide resolved
planner/core/find_best_task.go Outdated Show resolved Hide resolved
time-and-fate
time-and-fate reviewed Aug 2, 2022
View reviewed changes
planner/core/plan_cost_detail.go Outdated
Comment on lines 33 to 37
opt.appendPlanCostDetail(p).
appendParamCostDetail(RowSizeLbl, rowSize).
appendParamCostDetail(NetworkFactorLbl, networkFactor).
appendParamCostDetail(SeekFactorLbl, seekFactor).
appendCurrCostDesc(fmt.Sprintf("%s * %s + %s", RowSizeLbl, NetworkFactorLbl, SeekFactorLbl))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get why we need this logic.
I think just inserting the new PhysicalPlanCostDetail into the map[int]*PhysicalPlanCostDetail has the same effect and is much simpler.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

time-and-fate
time-and-fate reviewed Aug 2, 2022
View reviewed changes
planner/core/plan_cost_detail.go Outdated Show resolved Hide resolved
planner/core/plan_cost_detail.go Outdated Show resolved Hide resolved
planner/core/plan_cost_detail.go Outdated Show resolved Hide resolved
@Yisaer
address the comment
b5c5746 
Signed-off-by: yisaer <[email protected]>
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 3, 2022
@Yisaer
Copy link
Contributor Author

Yisaer commented Aug 3, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b5c5746

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 3, 2022
@Yisaer
Copy link
Contributor Author

Yisaer commented Aug 3, 2022

/merge

1 similar comment
@Yisaer
Copy link
Contributor Author

Yisaer commented Aug 3, 2022

/merge

@Yisaer
Copy link
Contributor Author

Yisaer commented Aug 3, 2022

/merge

@Yisaer
Copy link
Contributor Author

Yisaer commented Aug 3, 2022

/merge

@Yisaer
Copy link
Contributor Author

Yisaer commented Aug 3, 2022

/merge

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Aug 3, 2022
@Yisaer
Copy link
Contributor Author

Yisaer commented Aug 3, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a48fbf0

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 3, 2022
@Yisaer
Copy link
Contributor Author

Yisaer commented Aug 3, 2022

/merge

@ti-chi-bot
Copy link
Member

@Yisaer: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 8e9e839 into pingcap:master Aug 3, 2022
@Yisaer Yisaer mentioned this pull request Aug 8, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@time-and-fate time-and-fate time-and-fate approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

@qw4990 qw4990 Awaiting requested review from qw4990

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Yisaer @ti-chi-bot @sre-bot @hawkingrei @time-and-fate