-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
log-backup: restore meta kv with batch method #37100
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
@joccau: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
e2fc5e7
to
a11eee4
Compare
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/48461beccd28a51538225562824fb18b2db91536 |
Signed-off-by: joccau <[email protected]>
a11eee4
to
e1e66b5
Compare
Signed-off-by: joccau <[email protected]>
/run-all-tests |
1 similar comment
/run-all-tests |
Signed-off-by: joccau <[email protected]>
… into fix-restore-dup-metakv
/cc @YuJuncen PTAL |
@joccau: GitHub didn't allow me to request PR reviews from the following users: PTAL. Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: a438eb0
|
TiDB MergeCI notify🔴 Bad News! New failing [1] after this pr merged.
|
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-6.2 in PR #37139 |
Signed-off-by: joccau [email protected]
What problem does this PR solve?
Issue Number: close #37111
Problem Summary:
What is changed and how it works?
Set a lots of batch kv files and sort and restore these kv entries in batch files.
Check List
Tests
Manual test
MySQL [(none)]> show create table test.sbtest43; | sbtest43 | CREATE TABLE
sbtest43(
idint(11) NOT NULL AUTO_INCREMENT,
kint(11) NOT NULL DEFAULT '0',
cchar(120) NOT NULL DEFAULT '',
padchar(60) NOT NULL DEFAULT '', PRIMARY KEY (
id) /*T![clustered_index] CLUSTERED */ ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_bin AUTO_INCREMENT=1019915 |
MySQL [(none)]> show create table test.sbtest43; | sbtest43 | CREATE TABLE
sbtest43(
idint(11) NOT NULL AUTO_INCREMENT,
kint(11) NOT NULL DEFAULT '0',
cchar(120) NOT NULL DEFAULT '',
padchar(60) NOT NULL DEFAULT '', PRIMARY KEY (
id) /*T![clustered_index] CLUSTERED */, KEY
k_43(
k) ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_bin AUTO_INCREMENT=1019915 |
The Key
K-43
(``) has been restored in above test.Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.