-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: only create snapshot interceptor for temporary table when needed #37225
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/31aebb39e8184f9eeb964a6fa5fd707478f0f0a9 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 417a204
|
/run-mysql-test |
TiDB MergeCI notify
|
What problem does this PR solve?
Issue Number: close #37223
What is changed and how it works?
Add a new method
HasTemporaryTable
toinfoschema.InfoSchema
to tell if any temporary table exists. When will set a snapshot interceptor when this method returns true instead of setting it every time. Notice that when local temporary table is created in txn, we should also set the interceptor to the txn's snapshot.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.