-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sessionctx/variable: fix range check for @@timestamp #37249
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/ef78378b6bf18b789483e707d02ff0c54401cad4 |
PTAL @morgo @CbcWestwolf @xhebox |
/run-mysql-test |
1 similar comment
/run-mysql-test |
/run-mysql-test tidb-test=pr/1937 |
/run-mysql-test tidb-test=pr/1937 |
2 similar comments
/run-mysql-test tidb-test=pr/1937 |
/run-mysql-test tidb-test=pr/1937 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: ef78378
|
/merge |
/run-mysql-test tidb-test=pr/1937 |
TiDB MergeCI notify🔴 Bad News! New failing [1] after this pr merged.
|
What problem does this PR solve?
Issue Number: close #31585
Problem Summary:
What is changed and how it works?
This PR generally follows the suggestion from @morgo in #31585.
Check List
Tests
As shown in Tidb SET TIMESTAMP=3147483698 out of range is not compatible with mysql. #31585:
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.