Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sessionctx/variable: fix range check for @@timestamp #37249

Merged
merged 2 commits into from
Aug 23, 2022

Conversation

bb7133
Copy link
Member

@bb7133 bb7133 commented Aug 21, 2022

What problem does this PR solve?

Issue Number: close #31585

Problem Summary:

What is changed and how it works?

This PR generally follows the suggestion from @morgo in #31585.

Check List

Tests

mysql> SET TIMESTAMP=3147483698;
ERROR 1231 (42000): Variable 'timestamp' can't be set to the value of '3147483698'
-- Retain previously set  timestamp

Side effects

  • Performance regression: Consumes more CPU
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains variable changes
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix the issue that when setting a timestamp that is larger than `MAXINT32`, TiDB doesn't report an error like MySQL.

@bb7133 bb7133 requested a review from a team as a code owner August 21, 2022 10:51
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 21, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CbcWestwolf
  • ngaut

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 21, 2022
@bb7133 bb7133 added compatibility-breaker Violation of forwards/backwards compatibility in a design-time piece. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 21, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Aug 21, 2022

@bb7133
Copy link
Member Author

bb7133 commented Aug 21, 2022

PTAL @morgo @CbcWestwolf @xhebox

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 21, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 21, 2022
@hawkingrei
Copy link
Member

/run-mysql-test

1 similar comment
@hawkingrei
Copy link
Member

/run-mysql-test

@xhebox
Copy link
Contributor

xhebox commented Aug 23, 2022

/run-mysql-test tidb-test=pr/1937

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 23, 2022
@xhebox
Copy link
Contributor

xhebox commented Aug 23, 2022

/run-mysql-test tidb-test=pr/1937

2 similar comments
@xhebox
Copy link
Contributor

xhebox commented Aug 23, 2022

/run-mysql-test tidb-test=pr/1937

@xhebox
Copy link
Contributor

xhebox commented Aug 23, 2022

/run-mysql-test tidb-test=pr/1937

@bb7133
Copy link
Member Author

bb7133 commented Aug 23, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ef78378

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 23, 2022
@jackysp
Copy link
Member

jackysp commented Aug 23, 2022

/merge

@xhebox
Copy link
Contributor

xhebox commented Aug 23, 2022

/run-mysql-test tidb-test=pr/1937

@ti-chi-bot ti-chi-bot merged commit 2c22fff into pingcap:master Aug 23, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Aug 23, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/common-test 🟥 failed 1, success 10, total 11 13 min New failing
idc-jenkins-ci-tidb/integration-common-test 🔴 failed 4, success 13, total 17 17 min Existing failure
idc-jenkins-ci/integration-cdc-test 🟢 all 36 tests passed 32 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 7 min 34 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 49 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 5 min 35 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 3 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 34 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 56 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@bb7133 bb7133 deleted the bb7133/fix_31585 branch December 29, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility-breaker Violation of forwards/backwards compatibility in a design-time piece. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tidb SET TIMESTAMP=3147483698 out of range is not compatible with mysql.
10 participants