Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sessionctx: Change default tidb_partition_prune_mode from static to dynamic #37712

Merged
merged 7 commits into from
Sep 14, 2022
Merged

sessionctx: Change default tidb_partition_prune_mode from static to dynamic #37712

merged 7 commits into from
Sep 14, 2022

Conversation

mjonss
Copy link
Contributor

@mjonss mjonss commented Sep 8, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #37713

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Change the tidb_partition_prune_mode default to dynamic instead of static

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 8, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • morgo

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/invalid-title release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 8, 2022
@mjonss mjonss changed the title Change default tidb_partition_prune_mode from static to dynamic sessionctx: Change default tidb_partition_prune_mode from static to dynamic Sep 8, 2022
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/invalid-title release-note-none Denotes a PR that doesn't merit a release note. labels Sep 8, 2022
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 8, 2022
@mjonss
Copy link
Contributor Author

mjonss commented Sep 8, 2022

/run-mysql-test

@mjonss mjonss marked this pull request as ready for review September 8, 2022 15:30
@mjonss mjonss requested a review from a team as a code owner September 8, 2022 15:30
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 8, 2022
@morgo morgo self-requested a review September 13, 2022 16:24
@mjonss
Copy link
Contributor Author

mjonss commented Sep 13, 2022

/run-unit-test

@mjonss
Copy link
Contributor Author

mjonss commented Sep 13, 2022

/run-mysql-test tidb-test=pr/1971

@mjonss
Copy link
Contributor Author

mjonss commented Sep 13, 2022

/run-mysql-test tidb-test=pr/1971

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 13, 2022
@mjonss mjonss requested a review from bb7133 September 14, 2022 09:42
bb7133
bb7133 approved these changes Sep 14, 2022
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Sep 14, 2022
@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Sep 14, 2022
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 14, 2022
@mjonss mjonss mentioned this pull request Sep 14, 2022
Closed
12 tasks
@hawkingrei
Copy link
Member

/run-mysql-test tidb-test=pr/1971

@hawkingrei
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 45e7f33

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 14, 2022
@ti-chi-bot ti-chi-bot merged commit c646842 into pingcap:master Sep 14, 2022
@mjonss mjonss mentioned this pull request Sep 14, 2022
Merged
12 tasks
@mjonss mjonss deleted the default-dyn-prune-mode branch September 14, 2022 12:26
@sre-bot
Copy link
Contributor

sre-bot commented Sep 14, 2022

TiDB MergeCI notify

🔴 Bad News! [3] CI still failing after this pr merged.
These failed integration tests don't seem to be introduced by the current PR.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/common-test 🔴 failed 1, success 10, total 11 25 min Existing failure
idc-jenkins-ci-tidb/integration-ddl-test 🔴 failed 1, success 5, total 6 23 min Existing failure
idc-jenkins-ci-tidb/integration-common-test 🔴 failed 4, success 13, total 17 8 min 11 sec Existing failure
idc-jenkins-ci/integration-cdc-test 🟢 all 37 tests passed 23 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 23 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 4 min 42 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 12 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 2 min 51 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 23 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@mjonss mjonss mentioned this pull request Sep 23, 2022
Closed
@kennedy8312 kennedy8312 mentioned this pull request Mar 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgo morgo morgo approved these changes

@bb7133 bb7133 bb7133 approved these changes

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make tidb_partition_prune_mode = 'dynamic' the default
6 participants
@mjonss @ti-chi-bot @hawkingrei @sre-bot @morgo @bb7133