Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix unstable test TestStaleReadProcessorWithSelectTable #37858

Merged
merged 4 commits into from
Dec 8, 2022

Conversation

YangKeao
Copy link
Member

Signed-off-by: YangKeao [email protected]

What problem does this PR solve?

Issue Number: close #37228

Problem Summary:

If the test takes more than 5 seconds to run, it will fail.

What is changed and how it works?

Extend the staleness in the test. The threshold is now extended to 100 seconds (just a random big number)

@YangKeao YangKeao added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 15, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 15, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/invalid-title do-not-merge/needs-triage-completed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 15, 2022
@YangKeao YangKeao changed the title Fix unstable test TestStaleReadProcessorWithSelectTable test: fix unstable test TestStaleReadProcessorWithSelectTable Sep 15, 2022
@YangKeao
Copy link
Member Author

I cannot read the test log (as it's 404 now 🤦 ). It's just a guess 🤔 .

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 19, 2022
@tangenta
Copy link
Contributor

tangenta commented Dec 1, 2022

@YangKeao Here is the new failed test log.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 8, 2022
@hawkingrei
Copy link
Member

/merge

@YangKeao
Copy link
Member Author

YangKeao commented Dec 8, 2022

@YangKeao here is new log. https://do.pingcap.net/jenkins/blue/rest/organizations/jenkins/pipelines/pingcap/pipelines/tidb/pipelines/ghpr_unit_test/runs/9739/nodes/49/steps/54/log/?start=0

Yes. After reading the log, I'm quite sure it would be fixed by this PR 😄 . Thanks for providing the information.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 02eca64

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 8, 2022
@ti-chi-bot ti-chi-bot merged commit 7134b7b into pingcap:master Dec 8, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Dec 8, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [1] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/mybatis-test 🔴 failed 1, success 0, total 1 4 min 10 sec Existing failure
idc-jenkins-ci/integration-cdc-test ✅ all 40 tests passed 24 min Fixed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 12 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 10 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 39 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 54 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 4 min 32 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 2 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 28 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unstable test TestStaleReadProcessorWithSelectTable
6 participants