Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sessionctx: add tidb_gogc_tuner_threshold #38432

Merged
merged 21 commits into from
Oct 20, 2022
Merged

sessionctx: add tidb_gogc_tuner_threshold #38432

merged 21 commits into from
Oct 20, 2022

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Oct 12, 2022 •
edited
Loading

… threshold

Signed-off-by: Weizhen Wang [email protected]

What problem does this PR solve?

Issue Number: close #38431

Problem Summary:

What is changed and how it works?

the threshold of GOGC tuner is lower than tidb_server_memory_limit_gc_trigger.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@hawkingrei hawkingrei requested a review from a team as a code owner October 12, 2022 12:05
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 12, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • wshwsh12
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 12, 2022
@hawkingrei hawkingrei changed the title sessionctx: add tidb_gogc_tuner_threshold_factor to control gogctuner… sessionctx: add tidb_gogc_tuner_threshold_factor Oct 12, 2022
@hawkingrei
Copy link
Member Author

/run-build

@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 13, 2022
@hawkingrei hawkingrei force-pushed the add_gogc_tuner_threshold_factor branch from 00aaa17 to fcd02c5 Compare October 13, 2022 04:14
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 13, 2022
@hawkingrei hawkingrei force-pushed the add_gogc_tuner_threshold_factor branch 3 times, most recently from 6acef54 to f8c641f Compare October 13, 2022 04:16
@hawkingrei hawkingrei changed the title sessionctx: add tidb_gogc_tuner_threshold_factor sessionctx: add tidb_gogc_tuner_threshold Oct 13, 2022
@hawkingrei hawkingrei assigned XuHuaiyu and unassigned XuHuaiyu Oct 13, 2022
@hawkingrei
sessionctx: add tidb_gogc_tuner_threshold_factor to control gogctuner…
d9f739e 
… threshold

Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
9e8cf5b 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
ded252b 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
eaf5da7 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
838295a 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
f50efec 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
447fbe0 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
44e5ea8 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei hawkingrei force-pushed the add_gogc_tuner_threshold_factor branch from 38105a3 to 44e5ea8 Compare October 14, 2022 07:17
@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Oct 19, 2022
@hawkingrei
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6d86b4c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 19, 2022
@hawkingrei
Copy link
Member Author

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 19, 2022
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Oct 20, 2022
@hawkingrei
Copy link
Member Author

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 20, 2022
@hawkingrei
update
dc94881 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
d756f00 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d756f00

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 20, 2022
@hawkingrei
Copy link
Member Author

/run-check_dev_2

@hawkingrei
Copy link
Member Author

/run-build

@ti-chi-bot ti-chi-bot merged commit c1666d1 into pingcap:master Oct 20, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Oct 20, 2022

TiDB MergeCI notify

🔴 Bad News! [1] CI still failing after this pr merged.
These failed integration tests don't seem to be introduced by the current PR.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🔴 failed 1, success 37, total 38 26 min Existing failure
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 23 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 8 min 42 sec Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 8 min 32 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 51 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 13 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 4 min 2 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 1 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 52 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@hawkingrei hawkingrei deleted the add_gogc_tuner_threshold_factor branch October 21, 2022 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wshwsh12 wshwsh12 wshwsh12 approved these changes

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@qw4990 qw4990 qw4990 approved these changes

@xhebox xhebox xhebox approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add variable to dynamically change the threshold of GOGC tuner
7 participants
@hawkingrei @ti-chi-bot @sre-bot @xhebox @qw4990 @XuHuaiyu @wshwsh12