-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br/restore: fixed restore sys tables #38547
Conversation
Signed-off-by: hillium <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
If the cluster to be restored has the same version with backup cluster, we might let itself create the special tables. Because the table ID for these tables are hardcoded in TiDB, restore them to another table ID may cause problems. When the cluster version is different, these tables has no effects and no need to be restored. |
@lance6716 Yep, but once the user wants to restore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ship it
/merge |
This pull request has been accepted and is ready to merge. Commit hash: ba1056b
|
@YuJuncen: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: hillium [email protected]
What problem does this PR solve?
Issue Number: close #38538
Problem Summary:
What is changed and how it works?
After this PR, we would give up for keeping table ID if table ID is greater than
MaxUInt32
.Check List
Tests
- [ ] No code
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
(This bug was introduced only in the master branch.)