executor: fix revoke result view bug

[wxbty]

Signed-off-by: x-shadow-man [email protected]

Fix bug in issue #38421
also on column-level privilege

What problem does this PR solve?

This pr mainly fixes the bug of 38421.
To this end, I added new unit test【TestRevokeTableSingle、TestRevokeTableSingleColumn】, and also modified the involved unit tests【TestRevokeTableScope、TestRevokeColumnScope】.

Issue Number: close #38421

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• dveeden
• xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[ti-chi-bot]

Welcome @wxbty!

It looks like this is your first PR to pingcap/tidb 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/tidb. 😃

[sre-bot]

All committers have signed the CLA.

[wxbty]

/cc @cfzjywxk @you06

[wxbty]

hi, @dveeden This pr also wants to get your advice,thx

[xhebox]

LGTM otherwise

[wxbty]

/cc @dveeden

[you06]

LGTM
Can you help fix a similar issue on column-level privilege?

CREATE user test;
GRANT SELECT(`Host`) ON `mysql`.`db` TO test;
REVOKE SELECT(`Host`) ON `mysql`.`db` FROM test;
SELECT * FROM `mysql`.`columns_priv`; -- Expected empty result set, but got the following rows
+------+-------+------+------------+-------------+---------------------+-------------+
| Host | DB    | User | Table_name | Column_name | Timestamp           | Column_priv |
+------+-------+------+------------+-------------+---------------------+-------------+
| %    | mysql | test | db         | Host        | 2022-10-26 16:01:23 |             |
+------+-------+------+------------+-------------+---------------------+-------------+
1 row in set (0.002 sec)

[wxbty]

LGTM Can you help fix a similar issue on column-level privilege?

CREATE user test;
GRANT SELECT(`Host`) ON `mysql`.`db` TO test;
REVOKE SELECT(`Host`) ON `mysql`.`db` FROM test;
SELECT * FROM `mysql`.`columns_priv`; -- Expected empty result set, but got the following rows
+------+-------+------+------------+-------------+---------------------+-------------+
| Host | DB    | User | Table_name | Column_name | Timestamp           | Column_priv |
+------+-------+------+------------+-------------+---------------------+-------------+
| %    | mysql | test | db         | Host        | 2022-10-26 16:01:23 |             |
+------+-------+------+------------+-------------+---------------------+-------------+
1 row in set (0.002 sec)

ok

[xhebox]

I have the permission of the x-shadow man repository, but I can't find the modification of the allow maintainers to edti option.

The button should be somewhere at the right side panel.

I think it is only available when pr is just opened. Do I need to reopen a pr? Or try again?

It is up to you. I suggest opening another PR with your repo will be easy. I'll merge the PR when I am notified.

Then Why does the merge operation take so long? until timeout

CI is always unstable somehow. And it does take a long time to run all tests.

[xhebox]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 8f840a0

[xhebox]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 59b4bfd

[wxbty]

/merge

When ci is passed, maybe you will merge successfully.

[xhebox]

/merge

When ci is passed, maybe you will merge successfully.

Yes, so I tag it as mergeable first. So I don't need to watch the PR to see tests are passed or not.

[xhebox]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 0cbd221

[wxbty]

/merge

When ci is passed, maybe you will merge successfully.

Yes, so I tag it as mergeable first. So I don't need to watch the PR to see tests are passed or not.

If this time unsuccessful, I will reopen it, I know how the new pr is set up

[wxbty]

/merhe

typo

[xhebox]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 4521a06