Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DDL: use new PD API to get TiFlash replica table regionCount #38571

Merged
merged 4 commits into from
Oct 28, 2022
Merged

DDL: use new PD API to get TiFlash replica table regionCount #38571

merged 4 commits into from
Oct 28, 2022

Conversation

hehechen
Copy link
Contributor

@hehechen hehechen commented Oct 20, 2022 •
edited
Loading

Signed-off-by: hehechen [email protected]

What problem does this PR solve?

Issue Number: close #38570

Problem Summary:
If the table with TiFlash replica has many regions, such as more than 1 million, the /pd/api/v1/stats/region called to get region count will bring large overhead to the PD and may affect OLTP workload.

What is changed and how it works?

use new PD API /pd/api/v1/stats/region?count to get TiFlash replica table regionCount

Check List

Tests

  • Unit test

  • Integration test

  • Manual test (add detailed scripts or steps below)
    Create table, split 1 million regions, set TiFlash replica 1.
    Before modified, flame graph of PD:
    image
    After modified, flame graph of PD:
    image

  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 20, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • breezewish
  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-triage-completed labels Oct 20, 2022
@hehechen hehechen marked this pull request as ready for review October 28, 2022 07:10
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 28, 2022
@hehechen
Copy link
Contributor Author

/run-build

@hehechen
Copy link
Contributor Author

/cc @breezewish @crazycs520 @CalvinNeo

CalvinNeo
CalvinNeo approved these changes Oct 28, 2022
View reviewed changes
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot
Copy link
Member

@CalvinNeo: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 28, 2022
@hehechen
Copy link
Contributor Author

/run-unit-test

windtalker
windtalker approved these changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 28, 2022
@breezewish
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e4ac84b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 28, 2022
@hehechen
Copy link
Contributor Author

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit e415cfa into pingcap:master Oct 28, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Oct 28, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/common-test 🟥 failed 1, success 10, total 11 13 min New failing
idc-jenkins-ci-tidb/integration-ddl-test 🔴 failed 2, success 4, total 6 29 min Existing failure
idc-jenkins-ci/integration-cdc-test 🟢 all 38 tests passed 22 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 19 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 50 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 6 min 22 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 21 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 0 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 2 min 52 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@breezewish breezewish added the needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. label Oct 28, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 28, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #38732.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Oct 28, 2022
@ti-chi-bot
This is an automated cherry-pick of pingcap#38571
24c1111 
Signed-off-by: ti-chi-bot <[email protected]>
hehechen pushed a commit to hehechen/tidb that referenced this pull request Jan 6, 2023
This is an automated cherry-pick of pingcap#38571
56fc651 
Signed-off-by: ti-chi-bot <[email protected]>
ti-chi-bot added a commit that referenced this pull request Jan 9, 2023
@ti-chi-bot
DDL: use new PD API to get TiFlash replica table regionCount (#38571) (…
7c4ec4c 
…#38732)

close #38570
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CalvinNeo CalvinNeo CalvinNeo approved these changes

@breezewish breezewish breezewish approved these changes

@windtalker windtalker windtalker approved these changes

@crazycs520 crazycs520 Awaiting requested review from crazycs520

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TiFlash causes heavy PD pressure when there are many regions
6 participants
@hehechen @ti-chi-bot @breezewish @sre-bot @windtalker @CalvinNeo