-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: fix HashJoinExec panic of closed channel #38576
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/cc @bestwoody |
/cc @XuHuaiyu |
c8420b3
to
fc7c31c
Compare
9b163c7
to
62f4376
Compare
@bestwoody: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
is it safe to just set |
|
In response to a cherrypick label: new pull request created: #38666. |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created: #38667. |
In response to a cherrypick label: new pull request created: #38668. |
TiDB MergeCI notify🔴 Bad News! New failing [3] after this pr merged.
|
In response to a cherrypick label: new pull request created: #38712. |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created: #38713. |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created: #38714. |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created: #38715. |
Signed-off-by: ti-chi-bot <[email protected]>
What problem does this PR solve?
Issue Number: close #37932
Problem Summary:
What is changed and how it works?
Apply
willOpen
andClose
an operator multiple times. TheHashJoin
belowApply
returns an error in line 171 during Open, thuse.closeCh
is not re-initialized, and thee.closeCh
be closed inHashJoin.Close
is an already closed channel in the last round.To solve it, we set
e.closeCh
tonil
in theClose
function.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.