Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix HashJoinExec panic of closed channel #38576

Merged
merged 7 commits into from
Oct 26, 2022

Conversation

Qiaolin-Yu
Copy link
Contributor

@Qiaolin-Yu Qiaolin-Yu commented Oct 20, 2022

What problem does this PR solve?

Issue Number: close #37932

Problem Summary:

What is changed and how it works?

Apply will Open and Close an operator multiple times. The HashJoin below Apply returns an error in line 171 during Open, thus e.closeCh is not re-initialized, and the e.closeCh be closed in HashJoin.Close is an already closed channel in the last round.
To solve it, we set e.closeCh to nil in the Close function.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 20, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • LittleFall
  • XuHuaiyu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 20, 2022
@Qiaolin-Yu
Copy link
Contributor Author

/cc @bestwoody

@Qiaolin-Yu
Copy link
Contributor Author

/cc @XuHuaiyu

@Qiaolin-Yu Qiaolin-Yu marked this pull request as draft October 20, 2022 09:06
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 20, 2022
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 21, 2022
@Qiaolin-Yu Qiaolin-Yu marked this pull request as ready for review October 21, 2022 08:22
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 21, 2022
@XuHuaiyu XuHuaiyu changed the title HashJoinExec: fix panic of closed channel executor: fix HashJoinExec panic of closed channel Oct 21, 2022
@XuHuaiyu XuHuaiyu added the type/bugfix This PR fixes a bug. label Oct 21, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 21, 2022
@ti-chi-bot
Copy link
Member

@bestwoody: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@bestwoody
Copy link
Contributor

bestwoody commented Oct 21, 2022

is it safe to just set closeCh to nullptr. please ensure the user will check null of closeCh, and not do a null access.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 21, 2022
@Qiaolin-Yu
Copy link
Contributor Author

@Qiaolin-Yu Qiaolin-Yu closed this Oct 21, 2022
@ti-chi-bot ti-chi-bot merged commit e843278 into pingcap:master Oct 26, 2022
@Qiaolin-Yu Qiaolin-Yu deleted the fix_hashjoin branch October 26, 2022 12:18
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #38666.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Oct 26, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #38667.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #38668.

@sre-bot
Copy link
Contributor

sre-bot commented Oct 26, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [3] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test 🟥 failed 1, success 16, total 17 11 min New failing
idc-jenkins-ci-tidb/sqllogic-test-2 🟥 failed 2, success 26, total 28 6 min 2 sec New failing
idc-jenkins-ci-tidb/sqllogic-test-1 🟥 failed 4, success 22, total 26 4 min 14 sec New failing
idc-jenkins-ci-tidb/integration-ddl-test 🔴 failed 1, success 5, total 6 24 min Existing failure
idc-jenkins-ci-tidb/common-test 🔴 failed 2, success 9, total 11 11 min Existing failure
idc-jenkins-ci/integration-cdc-test 🟢 all 38 tests passed 21 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 32 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 3 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 53 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #38712.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Oct 28, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #38713.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Oct 28, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #38714.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Oct 28, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #38715.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TiDB panic: close of closed channel in HashJoinExec.Close
7 participants