-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: skip log timeout on maxExecutiontime as slow query for DDL statement. #38671
*: skip log timeout on maxExecutiontime as slow query for DDL statement. #38671
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
82e7338
to
8f72d79
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but we do have descriptions:
Unlike in MySQL, the max_execution_time system variable currently works on all kinds of statements in TiDB, not only restricted to the SELECT statement. The precision of the timeout value is roughly 100ms. This means the statement might not be terminated in accurate milliseconds as you specify.
https://docs.pingcap.com/tidb/dev/system-variables#max_execution_time
This should be investigated.
This Note is not correct, currently we do not support max_execution_time on all kinds of statements in TiDB. |
#10541 According to this PR, I think your argument makes more sense. Then https://github.com/pingcap/docs-cn/blob/master/develop/dev-guide-timeouts-in-tidb.md and its english version needs to be modified along this PR. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: f3d2466
|
/run-build |
1 similar comment
/run-build |
TiDB MergeCI notify✅ Well Done! New fixed [1] after this pr merged.
|
What problem does this PR solve?
When user issue an long run DDL statement, it should not be checked in maxExecutionTime for slow query checking mechanism.
Issue Number: close #38580
Problem Summary:
Just Skip none query type statements max execution time checking and kill them.
What is changed and how it works?
Check List
Tests