Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txn: tidb_constraint_check_in_place_pessimistic should not be global scoped (#38767) #38922

Merged

Conversation

ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Nov 7, 2022

This is an automated cherry-pick of #38767

What problem does this PR solve?

Issue Number: close #38766

Problem Summary:

Changing this variable can lead to unexpected results. Internals sessions shouldn't be affected by it as well, e.g. the imeplementation of get_lock() depends on tidb_contraint_check_in_place_pessimistic=1 to work.
We should only allow sessions that are aware of its effects to use it.

What is changed and how it works?

  • Change the scope of tidb_constraint_check_in_place_pessimistic to session only.
  • Add a config item pessimistic-txn.constraint-check-in-place-pessimistic to control the default value of the session variable.
  • Don't let it take effect in restricted SQLs.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Manually tested the config can affect the default value of the variable.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Variable `tidb_constraint_check_in_place_pessimistic` is made session scope only.
Add a new config item `pessimistic-txn.constraint_check_in_place_pessimistic` to control the default value of the variable.

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Nov 7, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • cfzjywxk
  • sticnarf

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.4 do-not-merge/cherry-pick-not-approved labels Nov 7, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 7, 2022
Copy link
Contributor

@sticnarf sticnarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 7, 2022
@cfzjywxk
Copy link
Contributor

cfzjywxk commented Nov 7, 2022

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 4885377

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 7, 2022
@ekexium
Copy link
Contributor

ekexium commented Nov 7, 2022

/run-check_dev_2

2 similar comments
@ekexium
Copy link
Contributor

ekexium commented Nov 7, 2022

/run-check_dev_2

@ekexium
Copy link
Contributor

ekexium commented Nov 7, 2022

/run-check_dev_2

@sre-bot sre-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Nov 7, 2022
@purelind
Copy link
Contributor

purelind commented Nov 7, 2022

/run-check_dev_2

@ti-chi-bot ti-chi-bot merged commit 2b88090 into pingcap:release-6.4 Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants