-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: fix panic when reusing OptimisticTxnContextProvider
#38952
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/check-issue-triage-complete |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: d45eacc
|
TiDB MergeCI notify🔴 Bad News! New failing [1] after this pr merged.
|
What problem does this PR solve?
Issue Number: close #38951
Problem Summary:
To reduce space allocation, we used to reserve
OptimisticTxnContextProvider
to txnManager that cause the old and newOptimisticTxnContextProvider
be the same. AfterResetForNewTxn
, the old provider's state will be corrputed.It is triggered when new MDL codes merged, see: #38926 (comment)
What is changed and how it works?
Reserve two
OptimisticTxnContextProvider
and make the old and the new one not the same.Check List
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.