ddl: fix return duplicate schema version during multi-schema change #39093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
ti-chi-bot
added
size/S
ti-chi-bot
added
size/M
Defined2014
changed the title
tangenta
approved these changes
Nov 14, 2022
tangenta
reviewed
Nov 14, 2022
ddl/multi_schema_change.go
Outdated
| ver, err = w.runDDLJob(d, t, &proxyJob) | ||
| sub.FromProxyJob(&proxyJob, ver) | ||
| proxyJobVer, err := w.runDDLJob(d, t, &proxyJob) | ||
| if !proxyJob.MultiSchemaInfo.SkipVersion { |
There was a problem hiding this comment.
Suggested change
| if !proxyJob.MultiSchemaInfo.SkipVersion { | |
| if !schemaVersionGenerated { |
There was a problem hiding this comment.
The schemaVersionGenerated here always equal to true.
There was a problem hiding this comment.
Improve it by another way, please check again.
tangenta
approved these changes
Nov 14, 2022
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: a5ac738
|
ti-chi-bot
added
the
status/can-merge
TiDB MergeCI notify✅ Well Done! New fixed [2] after this pr merged.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #39090
Problem Summary: multi-schema change will return same non-zero version in some scenarios which block MDL forever. We should prevent it.
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.