Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: support the view hint #39158

Merged
merged 12 commits into from
Nov 17, 2022
Merged

planner: support the view hint #39158

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ec7af19
planner: support the view hint
Reminiscent Nov 14, 2022
b075ecb
git add more test cases
Reminiscent Nov 15, 2022
01aafcd
update the test cases
Reminiscent Nov 15, 2022
edfafbc
update the test cases
Reminiscent Nov 15, 2022
8ac5c0b
update the test cases
Reminiscent Nov 15, 2022
31af17a
fix
Reminiscent Nov 15, 2022
19d0b84
Update planner/core/logical_plan_builder.go
Reminiscent Nov 15, 2022
1397b35
Update planner/core/logical_plan_builder.go
Reminiscent Nov 15, 2022
97722b7
Merge branch 'Delivery-cp' of https://github.com/Reminiscent/tidb int…
Reminiscent Nov 15, 2022
0232206
update
Reminiscent Nov 15, 2022
845f460
update
Reminiscent Nov 16, 2022
85643c7
Merge branch 'release-6.1-20220824' into Delivery-cp
ti-chi-bot Nov 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion executor/infoschema_reader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -688,7 +688,7 @@ func (e *hugeMemTableRetriever) dataForColumnsInTable(ctx context.Context, sctx
if err := runWithSystemSession(sctx, func(s sessionctx.Context) error {
planBuilder, _ := plannercore.NewPlanBuilder().Init(s, is, &hint.BlockHintProcessor{})
var err error
viewLogicalPlan, err = planBuilder.BuildDataSourceFromView(ctx, schema.Name, tbl)
viewLogicalPlan, err = planBuilder.BuildDataSourceFromView(ctx, schema.Name, tbl, nil, nil)
return errors.Trace(err)
}); err != nil {
sctx.GetSessionVars().StmtCtx.AppendWarning(err)
Expand Down
2 changes: 1 addition & 1 deletion executor/show.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1904,7 +1904,7 @@ func tryFillViewColumnType(ctx context.Context, sctx sessionctx.Context, is info
return runWithSystemSession(sctx, func(s sessionctx.Context) error {
// Retrieve view columns info.
planBuilder, _ := plannercore.NewPlanBuilder().Init(s, is, &hint.BlockHintProcessor{})
if viewLogicalPlan, err := planBuilder.BuildDataSourceFromView(ctx, dbName, tbl); err == nil {
if viewLogicalPlan, err := planBuilder.BuildDataSourceFromView(ctx, dbName, tbl, nil, nil); err == nil {
viewSchema := viewLogicalPlan.Schema()
viewOutputNames := viewLogicalPlan.OutputNames()
for _, col := range tbl.Columns {
Expand Down
Loading