Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explain : Support more info from tiflash in explain analyze #39216

Merged
merged 29 commits into from
Nov 28, 2022
Merged

Explain : Support more info from tiflash in explain analyze #39216

merged 29 commits into from
Nov 28, 2022

Conversation

hongyunyan
Copy link
Contributor

@hongyunyan hongyunyan commented Nov 17, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #39273

Problem Summary:

Enrich the information about FullTableScan operator of TiFlash in explain analyze.

What is changed and how it works?

Relate PRs:
pingcap/tipb#278 (need merge first)
pingcap/tiflash#6314

Examples:
image

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 17, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • breezewish
  • crazycs520

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 17, 2022
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 18, 2022
@hongyunyan hongyunyan changed the title WIP: support more info from tiflash in explain analyze Explain : Support more info from tiflash in explain analyze Nov 21, 2022
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 21, 2022
This was referenced Nov 21, 2022
Merged
Merged
@hongyunyan
Copy link
Contributor Author

/cc @JaySon-Huang @breezewish @SeaRise

@breezewish
Copy link
Member

@crazycs520 Please help take a look, Thanks!

@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Nov 28, 2022
@hongyunyan
Copy link
Contributor Author

/rebuild

@hongyunyan
Copy link
Contributor Author

/run-check_dev_2

@hongyunyan
Copy link
Contributor Author

/run-mysql-test

@hongyunyan
Copy link
Contributor Author

/run-unit-test

@hongyunyan
Copy link
Contributor Author

/rebuild

@hongyunyan
Copy link
Contributor Author

/build

@hongyunyan
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@hongyunyan: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@xhebox
Copy link
Contributor

xhebox commented Nov 28, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8b1e65e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 28, 2022
@hongyunyan
Copy link
Contributor Author

/rebuild

@hongyunyan
Copy link
Contributor Author

/run-check_dev

@hongyunyan
Copy link
Contributor Author

/run-check_dev_2

@hongyunyan
Copy link
Contributor Author

/run-mysql-test

@hongyunyan
Copy link
Contributor Author

/run-unit-test

@hongyunyan
Copy link
Contributor Author

/build

@hongyunyan
Copy link
Contributor Author

/rerun

@ti-chi-bot ti-chi-bot merged commit 594d20d into pingcap:master Nov 28, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Nov 28, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [1] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-ddl-test ✅ all 6 tests passed 6 min 20 sec Fixed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 25 min Existing passed
idc-jenkins-ci/integration-cdc-test 🟢 all 40 tests passed 21 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 9 min 32 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 6 min 31 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 12 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 53 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 39 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 52 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazycs520 crazycs520 crazycs520 approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@breezewish breezewish breezewish approved these changes

@SeaRise SeaRise Awaiting requested review from SeaRise

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@hongyunyan @ti-chi-bot @breezewish @JaySon-Huang @xhebox @sre-bot @crazycs520