ddl: fix tidb_ddl_enable_fast_reorg default on ut failed problem #39350
Conversation
|
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
do-not-merge/needs-triage-completed
release-note-none
|
/run-check-issue-triage-complete |
|
/run-all-test |
|
/run-check-issue-triage-complete |
|
/run-test |
|
/run-build |
|
/run-check_dev_2 |
|
/run-mysql-test |
|
/run-unit-test |
| } | ||
| done, ver, err = runReorgJobAndHandleErr(w, d, t, job, tbl, indexInfo, false) | ||
| if err != nil { | ||
| ingest.LitBackCtxMgr.Unregister(job.ID) | ||
| tryFallbackToTxnMerge(job, err) | ||
| return false, ver, errors.Trace(err) | ||
| return false, ver, nil |
There was a problem hiding this comment.
How about the line 823?
} else {
logutil.BgLogger().Warn("[ddl] lightning import error", zap.Error(err))
line 823-> tryFallbackToTxnMerge(job, err)
}
What problem does this PR solve?
Issue Number: close #39321
Problem Summary:
When set fast reorg variable on, some ut will failed.
What is changed and how it works?
This Case should check key in correct index and skip deleted key.
This four case is dur to pd create rollback DDL, we set err to nil and DDL task will be resumed and executed later
skip merge woker number checker.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.