Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: skip the error when fallback from ingest to txn method #39360

Merged

Conversation

Benjamin2037
Copy link
Collaborator

@Benjamin2037 Benjamin2037 commented Nov 24, 2022

What problem does this PR solve?

Issue Number: ref #39321

Problem Summary:
When set fast reorg variable on, some ut will failed.

What is changed and how it works?

TestCancel
TestMultiSchemaChangeAddIndexesCancelled
TestCancelAddIndexPanic
TestDDLStatsInfo
TestPartitionAddIndexGC

This four case is dur to pd create rollback DDL, we set err to nil and DDL task will be resumed and executed later

TestRunDDLJobPanicEnableClusteredIndex
TestRunDDLJobPanicDisableClusteredIndex

skip merge woker number checker.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 24, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 24, 2022
ddl/index.go Outdated Show resolved Hide resolved
@tangenta tangenta changed the title ddl: fix tidb_ddl_enable_fast_reorg default on ut failed problem part 1 ddl: skip the error when fallback from ingest to txn method Nov 24, 2022
@Benjamin2037
Copy link
Collaborator Author

/run-check_dev_2

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 24, 2022
@Benjamin2037
Copy link
Collaborator Author

/run-check_dev_2

@Benjamin2037
Copy link
Collaborator Author

/run-check_dev_2

@Benjamin2037
Copy link
Collaborator Author

/run-check_dev_2

2 similar comments
@Benjamin2037
Copy link
Collaborator Author

/run-check_dev_2

@Benjamin2037
Copy link
Collaborator Author

/run-check_dev_2

@Benjamin2037
Copy link
Collaborator Author

/run-all-tests

@wuhuizuo
Copy link
Contributor

/run-all-tests

1 similar comment
@wuhuizuo
Copy link
Contributor

/run-all-tests

@wuhuizuo
Copy link
Contributor

/run-build

ddl/index.go Outdated Show resolved Hide resolved
@Benjamin2037
Copy link
Collaborator Author

/run-mysql-test

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 25, 2022
@Benjamin2037
Copy link
Collaborator Author

/merge

@ti-chi-bot
Copy link
Member

@Benjamin2037: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@hawkingrei
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ebc9852

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 25, 2022
@ti-chi-bot ti-chi-bot merged commit ebc4e43 into pingcap:master Nov 25, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Nov 25, 2022

TiDB MergeCI notify

🔴 Bad News! [1] CI still failing after this pr merged.
These failed integration tests don't seem to be introduced by the current PR.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/mybatis-test 🔴 failed 1, success 0, total 1 11 min Existing failure
idc-jenkins-ci/integration-cdc-test 🟢 all 39 tests passed 21 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 17 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 11 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 4 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 13 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 5 min 4 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 34 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 55 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants