Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: leader selection with tikv store balance score during the ebs data restore #39402

Merged
merged 19 commits into from
Nov 29, 2022
Merged

br: leader selection with tikv store balance score during the ebs data restore #39402

merged 19 commits into from
Nov 29, 2022

Conversation

fengou1
Copy link
Contributor

@fengou1 fengou1 commented Nov 26, 2022 •
edited
Loading

What problem does this PR solve?

balance the region leader selection

Issue Number: close #39404

Problem Summary:
backup cluster without workload. restore flashback has the hot store to handle. root cause is selection leader focus on some tikv.

What is changed and how it works?

flashback using the write key to the region instead of the delete key from RocksDB.
flashback request always sends to a region leader.

ebs restore has the following workflow:

  1. read all tikv region meta
  2. select a region leader
  3. assign region leader to tikv
  4. send flashback to the region leader

in AWS EBS, disk performance may slow, and sometimes backup happens on a cluster without any workload.

in the above circumstances, in one region, we have some peers have the same logterm, last index and commit index. those peers can be select as a region leader.

this PR to select the best leader for the region.

best means flashback request can be Evenly distributed all tikvs.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 26, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • joccau

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 26, 2022
3pointer
3pointer reviewed Nov 28, 2022
View reviewed changes
br/pkg/restore/util.go Outdated Show resolved Hide resolved
br/pkg/restore/util.go Outdated Show resolved Hide resolved
@fengou1
Copy link
Contributor Author

fengou1 commented Nov 28, 2022

/run-unit-test

@fengou1
Copy link
Contributor Author

fengou1 commented Nov 29, 2022

/run-check_dev

WangLe1321
WangLe1321 approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@WangLe1321 WangLe1321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@WangLe1321: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

joccau
joccau approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@joccau joccau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 29, 2022
3pointer
3pointer reviewed Nov 29, 2022
View reviewed changes
br/pkg/restore/util.go Outdated Show resolved Hide resolved
3pointer
3pointer approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@3pointer 3pointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 29, 2022
@fengou1
Copy link
Contributor Author

fengou1 commented Nov 29, 2022

/run-check_dev_2

@3pointer
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9300b80

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 29, 2022
@fengou1
Copy link
Contributor Author

fengou1 commented Nov 29, 2022

/run-check_dev_2

@fengou1
Copy link
Contributor Author

fengou1 commented Nov 29, 2022

/run-build

@fengou1
Copy link
Contributor Author

fengou1 commented Nov 29, 2022

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit d2ace99 into pingcap:master Nov 29, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Nov 29, 2022

TiDB MergeCI notify

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 25 min Existing passed
idc-jenkins-ci/integration-cdc-test 🟢 all 40 tests passed 21 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 10 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 6 min 44 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 6 min 23 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 6 min 21 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 12 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 52 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 3 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@fengou1 fengou1 deleted the ebs_optim branch November 30, 2022 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3pointer 3pointer 3pointer approved these changes

@WangLe1321 WangLe1321 WangLe1321 approved these changes

@joccau joccau joccau approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

br: ebs restore may cause region leaders assign on one tikv lead to all flashback request to one tikvs
7 participants
@fengou1 @ti-chi-bot @3pointer @sre-bot @WangLe1321 @joccau @hawkingrei