Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: fix br foreign key test #39607

Merged
merged 1 commit into from
Dec 5, 2022
Merged

br: fix br foreign key test #39607

merged 1 commit into from
Dec 5, 2022

Conversation

crazycs520
Copy link
Contributor

@crazycs520 crazycs520 commented Dec 5, 2022 •
edited
Loading

Signed-off-by: crazycs520 [email protected]

What problem does this PR solve?

Issue Number: close #39609

Problem Summary: The test is added in #39427, but the test has a mistake.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@crazycs520
fix test
ed6eee2 
Signed-off-by: crazycs520 <[email protected]>
@crazycs520 crazycs520 added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 5, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 5, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • YuJuncen
  • fengou1

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 5, 2022
@crazycs520
Copy link
Contributor Author

/run-integration-br-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 5, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 5, 2022
@crazycs520
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ed6eee2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 5, 2022
@crazycs520
Copy link
Contributor Author

/run-integration-br-tests

@ti-chi-bot ti-chi-bot merged commit 7a1ea93 into pingcap:master Dec 5, 2022
@crazycs520 crazycs520 deleted the fk-fix-br-test branch December 5, 2022 03:13
@crazycs520 crazycs520 mentioned this pull request Dec 5, 2022
Closed
crazycs520 added a commit to crazycs520/tidb that referenced this pull request Dec 5, 2022
@crazycs520
br: fix br foreign key test (pingcap#39607)
e7a5184
@crazycs520 crazycs520 mentioned this pull request Dec 5, 2022
Merged
12 tasks
@sre-bot
Copy link
Contributor

sre-bot commented Dec 5, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [1] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🔴 failed 1, success 39, total 40 25 min Existing failure
idc-jenkins-ci-tidb/common-test 🔴 failed 1, success 10, total 11 9 min 15 sec Existing failure
idc-jenkins-ci-tidb/integration-ddl-test 🔴 failed 1, success 5, total 6 4 min 42 sec Existing failure
idc-jenkins-ci-tidb/integration-common-test ✅ all 17 tests passed 11 min Fixed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 0 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 4 min 42 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 12 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 53 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 42 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

ti-chi-bot pushed a commit that referenced this pull request Dec 5, 2022
@crazycs520
br: fix br foreign key test (#39607) (#39610)
aedbd4f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengou1 fengou1 fengou1 approved these changes

@YuJuncen YuJuncen YuJuncen approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

failed test of br foreign key test
5 participants
@crazycs520 @ti-chi-bot @sre-bot @YuJuncen @fengou1