Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "planner: update the cost formula of IndexJoin+IndexLookup" #39704

Merged
merged 11 commits into from
Dec 7, 2022
Merged

Revert "planner: update the cost formula of IndexJoin+IndexLookup" #39704

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
40f8efd
Revert "planner: update the cost formula of IndexJoin+IndexLookup (#3…
qw4990 Dec 7, 2022
7b43792
Merge branch 'master' into revert-39617-model2-update
qw4990 Dec 7, 2022
b024676
Merge branch 'master' into revert-39617-model2-update
qw4990 Dec 7, 2022
75be2ec
Merge branch 'master' into revert-39617-model2-update
hawkingrei Dec 7, 2022
5bf3fb0
Merge branch 'master' into revert-39617-model2-update
qw4990 Dec 7, 2022
65e2287
Merge branch 'master' into revert-39617-model2-update
hawkingrei Dec 7, 2022
b3d156f
Merge branch 'master' into revert-39617-model2-update
hawkingrei Dec 7, 2022
7fd5a3d
Merge branch 'master' into revert-39617-model2-update
ti-chi-bot Dec 7, 2022
3f430b3
Merge branch 'master' into revert-39617-model2-update
ti-chi-bot Dec 7, 2022
a60aff0
Merge branch 'master' into revert-39617-model2-update
ti-chi-bot Dec 7, 2022
b15404b
Merge branch 'master' into revert-39617-model2-update
ti-chi-bot Dec 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions planner/core/plan_cost_ver2.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -593,11 +593,6 @@ func (p *PhysicalIndexJoin) getIndexJoinCostVer2(taskType property.TaskType, opt
// Use an empirical value batchRatio to handle this now.
// TODO: remove this empirical value.
batchRatio := 6.0
if _, isIndexLookUp := probe.(*PhysicalIndexLookUpReader); isIndexLookUp {
// IndexJoin + IndexLookUp has the risks to cause massive double-read requests,
// set the batchRatio to a lower value in this case for safety.
batchRatio = 1.5
}
probeCost := divCostVer2(mulCostVer2(probeChildCost, buildRows), batchRatio)

p.planCostVer2 = sumCostVer2(startCost, buildChildCost, buildFilterCost, buildTaskCost, divCostVer2(sumCostVer2(probeCost, probeFilterCost, hashTableCost), probeConcurrency))
Expand Down