-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
variable: fix outdated time shift for variable with TypeTime
#39720
Conversation
Signed-off-by: YangKeao <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-check-issue-triage-complete |
/run-mysql-test |
/run-mysql-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-unit-test |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: b32c29e
|
@YangKeao: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-unit-test |
In response to a cherrypick label: new pull request created: #39767. |
Signed-off-by: YangKeao [email protected]
What problem does this PR solve?
Issue Number: close #39719
Problem Summary:
The time shift for a time zone can differ in the history. For example,
Asia/Shanghai
is+0805
in the history. If the user set variable without timezone, and TiDB equipped it with local time zone by default. It'll result in an unexpected behavior.What is changed and how it works?
Use the now year, month and day. Actually any near enough date is fine (as the timezone shift doesn't change frequently, right?). I still use the current date to make it more robust.
Check List
Tests
Release note