json: implement json unary not with comparing to json(0) #40684
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: YangKeao [email protected]
What problem does this PR solve?
Issue Number: close #40683
Problem Summary:
The behavior of unary not for json value is different between TiDB and MySQL. TiDB converts the json to double and run unary not on it. MySQL compares the JSON with json integer 0.
What is changed and how it works?
I changed the behavior to be compatible with MySQL. The only concern is that I don't know whether returning a function in other function class is expected. I only noticed the
funcName
is different so I added a very ugly condition to overwrite thefuncName
, but I'm not sure whether it will have other problems (at least, I cannot overwrite thefuncName
for the caller...).Or anyone can provide better idea?
Check List
Tests
Release note