Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: when pushing topN down below proj, check whether topN.ByItems contains a column(with ID=0) generated by proj (#40593) #41177

Open
wants to merge 1 commit into
base: release-6.1
Choose a base branch
from

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #40593

What problem does this PR solve?

Issue Number: close #40535

Problem Summary:

The minimal reproduce step can be simplified to:

CREATE TABLE `t1` (
  `c1` bigint(20) NOT NULL DEFAULT '-2312745469307452950',
  `c2` datetime DEFAULT '5316-02-03 06:54:49',
  `c3` tinyblob DEFAULT NULL,
  PRIMARY KEY (`c1`) /*T![clustered_index] CLUSTERED */
) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_bin;

CREATE TABLE `t2` (
  `c1` set('kn8pu','7et','vekx6','v3','liwrh','q14','1met','nnd5i','5o0','8cz','l') DEFAULT '7et,vekx6,liwrh,q14,1met',
  `c2` float DEFAULT '1.683167',
  KEY `k1` (`c2`,`c1`),
  KEY `k2` (`c2`)
) ENGINE=InnoDB DEFAULT CHARSET=gbk COLLATE=gbk_chinese_ci;

( select   /*+ agg_to_cop()  */  locate( `t1`.`c3` , `t1`.`c3` ) as r0 , `t1`.`c3` as r1 from `t1` where not( IsNull( `t1`.`c1` ) )   order by r0,r1  ) union all ( select     concat_ws(',', `t2`.`c2` , `t2`.`c1` ) as r0 , `t2`.`c1` as r1 from `t2`    order by r0,r1  ) order by 1 limit 273;

logical plan before logicalOptimize:

*core.LogicalLimit
  *core.LogicalSort
    *core.LogicalUnionAll
      *core.LogicalProjection
        *core.LogicalSort
          *core.LogicalProjection
            *core.DataSource
      *core.LogicalProjection
        *core.LogicalSort
          *core.LogicalProjection
            *core.DataSource   

logical plan after logicalOptimize:

*core.LogicalTopN
  *core.LogicalUnionAll
    *core.LogicalProjection
      *core.LogicalProjection
        *core.LogicalTopN
          *core.DataSource
    *core.LogicalProjection
      *core.LogicalProjection
        *core.LogicalTopN <-
          *core.DataSource

In planner/core/task.go:*PhysicalTopN.attach2TaskTopN.ByItems contains a column that cannot be obtained from copTask.indexPlan, so the optimizer chooses to use copTask.tablePlan, but copTask.tablePlan is nil, this results in "null pointer dereference".

What is changed and how it works?

There is a column in topN.ByItems is generated by proj, when topN is pushed down below proj, topN cannot obtain the column from datasource, to fix this, we can check whether topN.ByItems contains a column(with ID=0) generated by proj, if so, proj will prevent the optimizer from pushing topN down.

  1. A column with ID=0 indicates that the column cannot be resolved by data source.
  2. To determine whether a column is generated by projection, we can check whether the child of proj contains the column.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 8, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 10, 2023
Copy link

ti-chi-bot bot commented Feb 6, 2024

@ti-chi-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev 8c4319c link true /test check-dev
idc-jenkins-ci-tidb/unit-test 8c4319c link true /test unit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/cherry-pick-not-approved ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants