planner: when pushing topN
down below proj
, check whether topN.ByItems
contains a column(with ID=0) generated by proj
(#40593)
#41177
+84
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #40593
What problem does this PR solve?
Issue Number: close #40535
Problem Summary:
The minimal reproduce step can be simplified to:
logical plan before
logicalOptimize
:logical plan after
logicalOptimize
:In
planner/core/task.go:*PhysicalTopN.attach2Task
:TopN.ByItems
contains a column that cannot be obtained fromcopTask.indexPlan
, so the optimizer chooses to usecopTask.tablePlan
, butcopTask.tablePlan
isnil
, this results in "null pointer dereference".What is changed and how it works?
There is a column in
topN.ByItems
is generated byproj
, whentopN
is pushed down belowproj
,topN
cannot obtain the column from datasource, to fix this, we can check whethertopN.ByItems
contains a column(with ID=0) generated byproj
, if so,proj
will prevent the optimizer from pushingtopN
down.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.