*: reduce the allocation of error constructing in DecodeTableID (#41301)

[ti-chi-bot]

This is an automated cherry-pick of #41301

Signed-off-by: iosmanthus [email protected]

What problem does this PR solve?

Issue Number: close #41300

Problem Summary:

The original decode process checks if the key is API v2 first, which will always fail while the user is using API V1. This will cause the code will read the stack every time it decodes the key, which is CPU/MEM expensive.

What is changed and how it works?

This pull request checks if the key is API V1 first, if it's not, then try API v2 decoding.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviours
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

*: reduce the allocation of error constructing in `DecodeTableID`

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• Benjamin2037
• ekexium

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[ti-chi-bot]

@iosmanthus: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[Benjamin2037]

LGTM

[Benjamin2037]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: a5c026b