Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: add 2pb logic and fix some bugs for partitionTopN #42334

Merged
merged 13 commits into from
Mar 17, 2023
Merged

planner: add 2pb logic and fix some bugs for partitionTopN #42334

merged 13 commits into from
Mar 17, 2023

Conversation

windtalker
Copy link
Contributor

@windtalker windtalker commented Mar 16, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #42321, ref #39792

Problem Summary:
partitionTopN lack of 2pb logic and have some bugs.

What is changed and how it works?

This pr merges the changes in #41763 and add the bug fix for #42321

  1. add in plan_2_pb, add the partition column for both topn and limit
  2. call resolve index for both topn and limit
  3. generate partition by column when limit is pushed down
  4. show partition by columns info in the result of explain when limit operator has partition by columns

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 16, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AilinKid
  • fixdb

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-triage-completed labels Mar 16, 2023
ghazalfamilyusa
ghazalfamilyusa suggested changes Mar 16, 2023
View reviewed changes
planner/core/logical_plans.go
@@ -163,6 +163,7 @@ type LogicalJoin struct {
rightPreferJoinType uint

EqualConditions []*expression.ScalarFunction
// NAEQConditions means null aware equal conditions, which is used for null aware semi joins.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this related to this PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is the changes from #41763, I can remove it.

planner/core/explain.go
str.WriteString(", count:")
str.WriteString(strconv.FormatUint(p.Count, 10))
return str.String()
buffer := bytes.NewBufferString("")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is better to differentiate Limit with partition by calling it WindowLimit and do not include partition by fields.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean adding a new PhysicalWindowLimit or just display as WindowLimit in the explain info? Adding a new PhysicalWindowLimit need a lots of changes, and I think we will miss the deadline if we wants to this :(

planner/core/explain.go
str.WriteString(", count:")
str.WriteString(strconv.FormatUint(p.Count, 10))
return str.String()
buffer := bytes.NewBufferString("")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above. I think it is better to differentiate TopN with partition by calling it WindowTopN and do not include partition by fields.

@ti-chi-bot
Copy link
Member

@ghazalfamilyusa: Request changes is only allowed for the reviewers in list.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

fixdb
fixdb approved these changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@fixdb fixdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 17, 2023
@windtalker
fix ut
5c852b6 
Signed-off-by: xufei <[email protected]>
@windtalker
Copy link
Contributor Author

/test unit-test

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 17, 2023
@AilinKid
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5c852b6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 17, 2023
@ti-chi-bot ti-chi-bot merged commit 4ae5be1 into pingcap:master Mar 17, 2023
@windtalker windtalker mentioned this pull request Mar 17, 2023
Closed
12 tasks
@windtalker windtalker deleted the partition_topn_fix branch October 23, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghazalfamilyusa ghazalfamilyusa ghazalfamilyusa requested changes

@AilinKid AilinKid AilinKid approved these changes

@fixdb fixdb fixdb approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Query returns wrong result if tidb_opt_derive_topn is on
6 participants
@windtalker @ti-chi-bot @AilinKid @fixdb @ghazalfamilyusa @LittleFall