Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

streamhelper/advancer: Fix owner transfer metric #42422

Merged
merged 2 commits into from
Sep 4, 2024
Merged

streamhelper/advancer: Fix owner transfer metric #42422

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
474dc77
remove LastCheckpoint metric after losing ownership
YuJuncen Mar 21, 2023
4ad66ba
make format
YuJuncen Mar 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions br/pkg/streamhelper/advancer_daemon.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ func (c *CheckpointAdvancer) Name() string {

func (c *CheckpointAdvancer) onStop() {
metrics.AdvancerOwner.Set(0.0)
metrics.LastCheckpoint.Reset()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about other metrics? should also reset them?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think perhaps we don't need to reset them before some problems with them evaluated. 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we put a comment here saying other metrics potentially need to be audit as well? And maybe a comment describing why do we need to reset checkpoint for this issue? I don't have context on this so just looking at the code I'm very clear what needs to be done. Thanks!

c.stopSubscriber()
}

Expand Down
Loading